From owner-freebsd-ppc@FreeBSD.ORG Mon Jan 28 14:12:52 2013 Return-Path: Delivered-To: freebsd-ppc@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 65DDB3C6 for ; Mon, 28 Jan 2013 14:12:52 +0000 (UTC) (envelope-from lukasz.wojcik@zoho.com) Received: from sender1.zohomail.com (sender1.zohomail.com [72.5.230.103]) by mx1.freebsd.org (Postfix) with ESMTP id 33C04D9D for ; Mon, 28 Jan 2013 14:12:51 +0000 (UTC) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=zapps768; d=zoho.com; h=message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type; b=Yl+FdHcQlUOu8ohhrhnsMrvNsRvg0NVhHWLhKewogRaEsqz4bMphij8m5T6yMgIBzF9Vsqo5h8Yd 1ni+XUnlnlehQ4rajqTEv4DbL7tS88Xzq2P6AkxL7a4JzREZ/Z51 Received: from [192.168.1.122] (89-74-151-203.dynamic.chello.pl [89.74.151.203]) by mx.zohomail.com with SMTPS id 1359379262911406.2379750990144; Mon, 28 Jan 2013 05:21:02 -0800 (PST) Message-ID: <51067BA4.7080402@zoho.com> Date: Mon, 28 Jan 2013 14:22:44 +0100 From: Lukasz Wojcik User-Agent: Mozilla/5.0 (X11; FreeBSD i386; rv:9.0) Gecko/20121028 Thunderbird/9.0 MIME-Version: 1.0 To: Aleksander Dutkowski Subject: Re: OpenFirmware issue on P1010 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External X-Zoho-Virus-Status: 2 Cc: freebsd-ppc@freebsd.org X-BeenThere: freebsd-ppc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to the PowerPC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jan 2013 14:12:52 -0000 On 01/25/13 13:10, Aleksander Dutkowski wrote: > hi! > > I am porting FreeBSD on P1010RDB platform. I modified existing MPC85XX > config (i.e. removed SMP), created p1010rdb.dts from p1020rdb.dts etc, > and ran the kernel via u-boot: > tftp 0x1000000 fbsd.elf > go 0x10000e0 > > Nothing happened, so I used CodeWarrior IDE with CW USB Tap, and it > turned out, that OF_install() call in sys/powerpc/booke/machedp.c > returns false. I inspected this function and moreover, I inspected the > structure, which is pointer from set_ofw_set linker set: > > $ powerpc-rtems-objdump -s kernel | grep set_ofw_set > Contents of section set_ofw_set: > c03694f0 c037ab54 .7.T > > (gdb) p (ofw_def_t)*0xc037ab54 > $1 = {name = 0xc03339a4 "ofw_fdt", methods = 0xc0319350, size = 0, > baseclasses = 0x0, refs = 0, ops = 0x0} > > As we can se, name field is correct. But this function seems to fail > in strcmp(). > I have found the issue [1] on bugtracker, so Im quite sure, that the > problem is ith linker sets on powerpc (but this issue is quite old now > ;) ), but the fix is not working for me - it crashes while compiling: > > cc -c -O -pipe -std=c99 -Wa,-me500 -g -Wall -Wredundant-decls > -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes > -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign > -fformat-extensions -Wmissing-include-dirs -fdiagnostics-show-option > -nostdinc -I. -I/usr/home/aleek/src/p1010-github/sys > -I/usr/home/aleek/src/p1010-github/sys/contrib/altq > -I/usr/home/aleek/src/p1010-github/sys/contrib/libfdt -D_KERNEL > -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common > -finline-limit=15000 --param inline-unit-growth=100 --param > large-function-growth=1000 -msoft-float -Wa,-many > -fno-omit-frame-pointer -msoft-float -mno-altivec -ffreestanding > -fstack-protector -Werror > /usr/home/aleek/src/p1010-github/sys/dev/ofw/openfirm.c > cc1: warnings being treated as errors > /usr/home/aleek/src/p1010-github/sys/dev/ofw/openfirm.c: In function > 'OF_install': > /usr/home/aleek/src/p1010-github/sys/dev/ofw/openfirm.c:126: warning: > assignment from incompatible pointer type > /usr/home/aleek/src/p1010-github/sys/dev/ofw/openfirm.c:126: warning: > comparison of distinct pointer types lacks a cast > > Do you have any idea, how to fix this? > > > > [1] http://www.freebsd.org/cgi/query-pr.cgi?pr=140241 Hi Aleksander, You did not mention the version (or commit) of FreeBSD you're using, so I'm unsure of what is the assignment mentioned in error msg; However, the compile-time error you're seeing seems to be really easy to fix, by doing proper type cast. -LW