From owner-cvs-all@FreeBSD.ORG  Sat Dec  2 08:59:53 2006
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id C109116A403;
	Sat,  2 Dec 2006 08:59:53 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2B03043CA5;
	Sat,  2 Dec 2006 08:59:34 +0000 (GMT)
	(envelope-from rwatson@FreeBSD.org)
Received: from fledge.watson.org (fledge.watson.org [209.31.154.41])
	by cyrus.watson.org (Postfix) with ESMTP id EEB0246EB9;
	Sat,  2 Dec 2006 03:59:52 -0500 (EST)
Date: Sat, 2 Dec 2006 08:59:52 +0000 (GMT)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: Alfred Perlstein <alfred@freebsd.org>
In-Reply-To: <20061202020221.GW38808@elvis.mu.org>
Message-ID: <20061202085757.H40536@fledge.watson.org>
References: <200611301502.kAUF22lU076210@repoman.freebsd.org>
	<456F0B71.3050604@errno.com> <20061130172634.GC75179@rambler-co.ru>
	<20061130174257.GY32700@FreeBSD.org>
	<20061202020221.GW38808@elvis.mu.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org,
	Gleb Smirnoff <glebius@FreeBSD.org>,
	Ruslan Ermilov <ru@FreeBSD.org>, Sam Leffler <sam@errno.com>
Subject: Re: cvs commit: src/sys/net if.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 02 Dec 2006 08:59:53 -0000

On Fri, 1 Dec 2006, Alfred Perlstein wrote:

> * Gleb Smirnoff <glebius@FreeBSD.org> [061130 09:46] wrote:
>> On Thu, Nov 30, 2006 at 08:26:34PM +0300, Ruslan Ermilov wrote:
>> R> BTW, is if_{watchdog|timer} also dangerous for !MPSAFE drivers?
>>
>> It isn't. AFAIR, Robert promised to remove all !MPSAFE NIC drivers before 
>> RELENG_7.
>
> Other than performance issues, what's the point of doing this?
>
> To me that sounds like we'd lose all of usb ethernet as it stands.  I'm fine 
> with fixing usb ethernet, but not under some thread-model of developement.

You have been pointed to the USB stack rewrite for 7.x at least three times in 
the last 24 hours.  Getting developers involved in reviewing and testing this 
work would be very useful.

The point of removing compatibility code for non-MPSAFE drivers is to remove 
compatibility code for non-MPSAFE drivers.  For entertainment value, grep -i 
giant in src/sys/net.  We go through some odd contortions to acquire Giant 
where it is needed, defer work to run under Giant, and so on.

Robert N M Watson
Computer Laboratory
University of Cambridge