Date: Thu, 24 Aug 2017 14:34:04 +0200 From: Romain =?iso-8859-1?Q?Tarti=E8re?= <romain@FreeBSD.org> To: Baptiste Daroussin <bapt@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, sobomax@FreeBSD.org Subject: Re: svn commit: r448610 - in head/devel/leatherman: . files Message-ID: <20170824123404.GA15557@blogreen.org> In-Reply-To: <20170824121232.GA31945@graf.pompo.net> References: <201708231317.v7NDHEGS099253@repo.freebsd.org> <20170823132505.s7kakyqgyb5tdy42@ivaldir.net> <20170823134551.GA13824@blogreen.org> <20170823134934.rjje72qwomm7sd6c@ivaldir.net> <20170823140836.GB13824@blogreen.org> <20170824121232.GA31945@graf.pompo.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--C7zPtVaVf+AK4Oqc Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 24, 2017 at 02:12:32PM +0200, Thierry Thomas wrote: > Le mer. 23 ao=FBt 17 =E0 16:08:36 +0200, Romain Tarti=E8re <romain@FreeBS= D.org> > =E9crivait=A0: >=20 > > Another point with `make makepatch`: in the post-patch target, I alter > > the patched source code. `make makepatch` wants the combined patches to > > be combined: > >=20 > > ---------------------------------- 8< ---------------------------------- > > -+ return "%%PREFIX%%/etc/facter/facter.conf"; > > ++ return "/usr/local/etc/facter/facter.conf"; > > ---------------------------------- 8< ---------------------------------- >=20 > This is why this kind of substitutions are better in pre-configure. > Logically, post-patch is for static replacements, not for variables > depending on the configuration options. Makes sense. I found a warkaround (make extract do-patch makepatch), but this solution seems definitively better. Thanks Thierry! --=20 Romain Tarti=E8re <romain@FreeBSD.org> http://people.FreeBSD.org/~romain/ pgp: 8234 9A78 E7C0 B807 0B59 80FF BA4D 1D95 5112 336F (ID: 0x5112336F) (plain text =3Dnon-HTML=3D PGP/GPG encrypted/signed e-mail much appreciated) --C7zPtVaVf+AK4Oqc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAEBCAAdFiEEgjSaeOfAuAcLWYD/uk0dlVESM28FAlmex7kACgkQuk0dlVES M29wRgv/butDeZogNjmi0aDJTuL46w59fsP5U8ROcs5nPDoPMosBujHT02VZRM1N PYiXlPFmkAe1czm2WnoijosIlbF1I/z5IdLM+5WI7RBAwZ+T7+tdx3yFl7W9rIqJ 4KafA05Uha4D2w08jipLA2M54vbcebRvExIqKScVhGtbiSrdBB953p0VC1JbVl13 GcUgdrrRRaY6L2ULI9Fmtn3Aujk3qACTf/ZqQqkkiXbwlT7od+/Xq5lP/aoT3w8e PF7Tlx4LoqNcHbXG/9SH/K8arzK1BoveO+YZWdC1e2aB0v4IXwE5ambI+OQ88bfu Zdt54Rog/AwOmCqQTIgafpZb/LBzvP74667HtXEZxFHPKVzhdXUSpDmyXZ74SZlb d8D/s5l4Ad7WutGhpIYjV1D5NTqAbwkfhzCt/w3eoOXJCqeEyPkMkdlMRXHRKCnq nPe+4o8UMwRc3JA52/cqEdWucnCPFJSWhXnMOAOwNk3TNeCrQRaUuTCtAgHpTMk8 UbOg1YcA =8tRu -----END PGP SIGNATURE----- --C7zPtVaVf+AK4Oqc--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170824123404.GA15557>