From nobody Sat Dec 6 14:28:16 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dNrFY2K0Zz6KmFb for ; Sat, 06 Dec 2025 14:28:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dNrFX6lK5z3xLS for ; Sat, 06 Dec 2025 14:28:16 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1765031296; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=II/dRkEN556Lq+HEkEfdda0JuUJ44oxrQLH+Lnop/Fo=; b=eo3A/a0VF9BkvbvvAOH/IBiRIFh+RkTDfVV9K2L4CmPudk/1doL5527V3BlbG6mWYffSn3 EmAbfKuT8zGm+sK9S/PCh9mamUCvmoZQP4kGE5hK6o66XOFgDGKF2VvwfTNd0gEctL83nq NzSLYJGw3W9hFp9It3KNJ4gtA81/q2yJWqus7bKZGqt53Xz/t89ghuAA4UtdKXGQMr2TVX idr2LiypUfypcOci6lk6C5FuTBQdUrbyuzfiP0+RzxMyAqPv6VmfKGBm+D/xnM+taRC9Bt zQzAjP+AjkmWrncbs0Paj3kADUO+h5jfyhZXls7cUA0B1XX9yOdkeUfEryODsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1765031296; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=II/dRkEN556Lq+HEkEfdda0JuUJ44oxrQLH+Lnop/Fo=; b=vOVCTTrIyaV5Wgi00FCcmk1zAHtRhV/KLvD5XuIaQNZOvvVTQYKlH4TKK7Hg5NVx3vENCq g2d7BR8qxsFB/A7MZsafwTW6C6GjF6U+o2RY+5jkNevWpX0r+OQUBbVxOqdQ4EYMVQyPM8 C5SxR5RVO2sCRdSphHrbHut2qImO4xALC/biheAq0pEWUQn7BxHjJ9Hcoz3Oa4f8G//zMR 1AFQnE+BHiJWN/qFk/2MDQKfjYdSxcGFldxeNS8HMAXZ671Nse+uQSicxyvfKY7maLmCCY WXv2GmnreYiMJrCvYn/JR5mWHdB7ztOEGA60IuOSbWWBHkjd02iJ1yAMiOvRUg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1765031296; a=rsa-sha256; cv=none; b=JT8kBZ/PouJ+L8tEwHhPKpt6XuJq+K+3/bvcWooQbTIxuJcnNbz8MWfjiaLC6xuI8Y7J5W jAK2No9lBNAd0QKlW5hsTNsF8KpFdo5QMGr71YFiwPSuww2rfG6HxjGiSomOeqb90dFsYI MfmmeNZebxgwXA8DNehQhHO8cA2RhNKoQlFVm7cLZPsRR54eSo4YS10ZuHLFqeZ3TtN118 YKiHkSbOtp1vae+tqNL3Bs7yoIU20fG21zBpsHzKD63TIOkc8XnwLkaOKzVlJ43GGM2d4C b3+IQV3nHs980fs2jOm+rzrY9K6Iyxh25NyXX+Wb40skp/ckIpn1cxGA4cfWwQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dNrFX6LYYz10TQ for ; Sat, 06 Dec 2025 14:28:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 298e5 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 06 Dec 2025 14:28:16 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Christos Margiolis Subject: git: 643a606fa274 - main - sndctl(8): Do not free and re-open device List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 643a606fa2742b94f6eca620119b7d2686ca9cd3 Auto-Submitted: auto-generated Date: Sat, 06 Dec 2025 14:28:16 +0000 Message-Id: <69343d80.298e5.3cd0cd8f@gitrepo.freebsd.org> The branch main has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=643a606fa2742b94f6eca620119b7d2686ca9cd3 commit 643a606fa2742b94f6eca620119b7d2686ca9cd3 Author: Christos Margiolis AuthorDate: 2025-12-06 14:28:08 +0000 Commit: Christos Margiolis CommitDate: 2025-12-06 14:28:08 +0000 sndctl(8): Do not free and re-open device There was a reason for this, but it does not apply anymore. Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D54031 --- usr.sbin/sndctl/sndctl.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/usr.sbin/sndctl/sndctl.c b/usr.sbin/sndctl/sndctl.c index 6977f0ab0ebe..e6dac67e2ea7 100644 --- a/usr.sbin/sndctl/sndctl.c +++ b/usr.sbin/sndctl/sndctl.c @@ -992,17 +992,10 @@ next: argv++; } - free_dev(dp); - if (show) { - /* - * Re-read dev to reflect new state in case we changed some - * property. - */ - dp = read_dev(path); print_dev(dp); - free_dev(dp); } + free_dev(dp); return (0); }