Date: Fri, 21 Jun 2013 01:53:27 GMT From: Kevin Zheng <kevinz5000@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/179798: [patch] Stop calling net-p2p/transmission-gtk a GTK2 client b/c it uses GTK3 Message-ID: <201306210153.r5L1rRp4018204@oldred.freebsd.org> Resent-Message-ID: <201306210200.r5L200pi089152@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 179798
>Category: ports
>Synopsis: [patch] Stop calling net-p2p/transmission-gtk a GTK2 client b/c it uses GTK3
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Fri Jun 21 02:00:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator: Kevin Zheng
>Release: 9.1-RELEASE-p4
>Organization:
>Environment:
FreeBSD sigma.local 9.1-RELEASE-p4 FreeBSD 9.1-RELEASE-p4 #0: Mon Jun 17 11:38:17 UTC 2013 root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC i386
>Description:
Thanks to the wonderful FreeBSD folks, we now have the latest version of Transmission in ports! Yay! Unfortunately somebody got too excited and forgot to tell their uses that the latest version uses GTK3 instead of GTK2. This is misleading and confusing.
While you're here, maybe you could trim the ABI versions from the Makefile unless their absolutely necessary (to pet portlint).
NOTE: I have NOT build-tested this patch because it really shouldn't break stuff.
>How-To-Repeat:
You build net-p2p/transmission-gtk but to your great despair the package system dares to call it "transmission-gtk2" (because of bad PKGNAMESUFFIX).
>Fix:
Apply the attached patch.
Patch attached with submission follows:
diff -ruN /usr/ports/net-p2p/transmission-gtk/Makefile transmission-gtk/Makefile
--- /usr/ports/net-p2p/transmission-gtk/Makefile 2013-04-24 13:10:30.000000000 -0500
+++ transmission-gtk/Makefile 2013-06-20 20:44:54.000000000 -0500
@@ -1,13 +1,14 @@
# $FreeBSD: net-p2p/transmission-gtk/Makefile 316464 2013-04-24 18:10:30Z ak $
-PKGNAMESUFFIX= -gtk2
+PKGNAMESUFFIX= -gtk
MAINTAINER= crees@FreeBSD.org
-COMMENT= Fast and lightweight GTK+2 BitTorrent client
+COMMENT= Fast and lightweight GTK BitTorrent client
LIB_DEPENDS= ${GEN_LIB_DEPENDS} \
notify.4:${PORTSDIR}/devel/libnotify \
dbus-glib-1.2:${PORTSDIR}/devel/dbus-glib
+
RUN_DEPENDS= ${GEN_RUN_DEPENDS} \
xdg-open:${PORTSDIR}/devel/xdg-utils
diff -ruN /usr/ports/net-p2p/transmission-gtk/pkg-descr transmission-gtk/pkg-descr
--- /usr/ports/net-p2p/transmission-gtk/pkg-descr 2012-07-14 09:29:18.000000000 -0500
+++ transmission-gtk/pkg-descr 2013-06-20 20:45:59.000000000 -0500
@@ -1,4 +1,4 @@
-A fast and lightweight GTK+2 BitTorrent client.
+A fast and lightweight GTK BitTorrent client.
Transmission has been built from the ground up to be a lightweight, yet
powerful BitTorrent client. Its simple, intuitive interface is designed
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201306210153.r5L1rRp4018204>