Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 2 May 2018 12:12:26 -0600
From:      Adam Weinberger <adamw@adamw.org>
To:        Steven Kreuzer <skreuzer@freebsd.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r468857 - in head/devel: . cpu_features
Message-ID:  <56A72AF2-EB6C-4411-B8EB-8D63159CE0B6@adamw.org>
In-Reply-To: <201805021720.w42HKuBC069211@repo.freebsd.org>
References:  <201805021720.w42HKuBC069211@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

> On 2 May, 2018, at 11:20, Steven Kreuzer <skreuzer@freebsd.org> wrote:
>
> Author: skreuzer
> Date: Wed May  2 17:20:56 2018
> New Revision: 468857
> URL: https://svnweb.freebsd.org/changeset/ports/468857
>
> Log:
>   A small, fast, and simple open source library to report CPU features at
>   runtime. Written in C89 for maximum portability, it allocates no memory and is
>   suitable for implementing fundamental functions and running in sandboxed
>   environments.
>
>   WWW: https://github.com/google/cpu_features
>
> Added:
>   head/devel/cpu_features/
>   head/devel/cpu_features/Makefile   (contents, props changed)
>   head/devel/cpu_features/distinfo   (contents, props changed)
>   head/devel/cpu_features/pkg-descr   (contents, props changed)
>   head/devel/cpu_features/pkg-plist   (contents, props changed)
> Modified:
>   head/devel/Makefile
>
> Modified: head/devel/Makefile
> ==============================================================================
> --- head/devel/Makefile	Wed May  2 17:16:40 2018	(r468856)
> +++ head/devel/Makefile	Wed May  2 17:20:56 2018	(r468857)
> @@ -361,6 +361,7 @@
>      SUBDIR += cppunit
>      SUBDIR += cpputest
>      SUBDIR += cproto
> +    SUBDIR += cpu_features
>      SUBDIR += cpuflags
>      SUBDIR += cquery
>      SUBDIR += cram
>
> Added: head/devel/cpu_features/Makefile
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/devel/cpu_features/Makefile	Wed May  2 17:20:56 2018	(r468857)
> @@ -0,0 +1,24 @@
> +# $FreeBSD$
> +
> +PORTNAME=	cpu_features
> +PORTVERSION=	0.1.0
> +DISTVERSIONPREFIX=	v
> +CATEGORIES=	devel
> +
> +MAINTAINER=	skreuzer@FreeBSD.org
> +COMMENT=	Cross platform C99 library to get cpu features at runtime
> +
> +LICENSE=	APACHE20
> +
> +USES=	cmake
> +USE_GITHUB=	yes
> +GH_ACCOUNT=	google
> +
> +do-install:
> +	${INSTALL_PROGRAM} ${WRKSRC}/list_cpu_features ${STAGEDIR}${PREFIX}/bin
> +	${INSTALL_LIB} ${WRKSRC}/libcpu_features.a ${STAGEDIR}${PREFIX}/lib

Hi Steven,

You don’t generally want to install static libraries with INSTALL_LIB,  
which strips stuff (and static libraries shouldn’t be stripped). I’m pretty  
sure you'll want to use INSTALL_DATA here instead.

# Adam


—
Adam Weinberger
adamw@adamw.org
http://www.adamw.org




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56A72AF2-EB6C-4411-B8EB-8D63159CE0B6>