From owner-svn-src-head@freebsd.org  Mon Mar 14 16:34:48 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id B029DAD0BFA;
 Mon, 14 Mar 2016 16:34:48 +0000 (UTC)
 (envelope-from adrian.chadd@gmail.com)
Received: from mail-ig0-x22a.google.com (mail-ig0-x22a.google.com
 [IPv6:2607:f8b0:4001:c05::22a])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 78F8F1E1;
 Mon, 14 Mar 2016 16:34:48 +0000 (UTC)
 (envelope-from adrian.chadd@gmail.com)
Received: by mail-ig0-x22a.google.com with SMTP id mh10so18618805igb.0;
 Mon, 14 Mar 2016 09:34:48 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date:message-id:subject
 :from:to:cc; bh=0ucUHqdg5zM2A3okVGvBzLP6bzg4/SucCp0BX7XTH30=;
 b=kxpHZUND832frqR+8/+C1CWBIzgjD5AOq/ZkA9H6jnxaaEL30UP1z606N0Vew4LAvg
 13AoswKxo1DXK1JUfB8a2b6x+LeBy+ZVxoOqWY+q4k5B9lpXHm4px2f5rJsVIwODbzYl
 es3bI/lPxi2imm+xzkZb052wUc1Fc+0tqNEv/3v0TTgb9FHhN0B13AQPiHcD/NiaE4Qc
 Yu00PtcMiZUwk8Ru0IuQwcK8HvEvypQUGQ94ri+crMxntYMnD+hvtn3YMw8xZEtufoPm
 mu3GkJtTkjBzOV03k4aLVS3eu2nPXhBb4taSgCqF6yzHAxysR0WJeQ96qnq4f2WaKeZO
 Yprw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:sender:in-reply-to:references:date
 :message-id:subject:from:to:cc;
 bh=0ucUHqdg5zM2A3okVGvBzLP6bzg4/SucCp0BX7XTH30=;
 b=E41Ya+lYiWaWQsU91OdfaYgSqCaP8tyP+qw46V8CY/10sDL/4ZUJDkT6rHLfqLDT8i
 uv2bHh78kNNSvlGDM0lfQwBKZuejk04+FWY/XvCOQzbAVnUomYaaNhYLp5daaVmqg4bJ
 f74yShr8Oz+R1slbaSIB1LkAT0kn8chnkv7uRDKdr5fgjStDnCnVilEHQQnt39YjKR00
 JnGzIPXPUV8nUX3Z0M+r3jF5Ck3xIbQMTGoPUS3aO88GlTndna40VgllMt90/ZR2owWy
 yAsNB5Ol/n2gGx4yI2cq81yaV9FEd7BOn5yAqtJZ4y4nSK8bZgCrjSuGlN+rIB7KjDqH
 NPsg==
X-Gm-Message-State: AD7BkJIidqzadIft3l32vqNc6eUIyWYs8xn4LmmS7GvhXBvbFLcNmTLVnDvAmttYCPSFF96V12SNbbGPedqKjA==
MIME-Version: 1.0
X-Received: by 10.50.67.180 with SMTP id o20mr14754527igt.37.1457973287946;
 Mon, 14 Mar 2016 09:34:47 -0700 (PDT)
Sender: adrian.chadd@gmail.com
Received: by 10.36.14.19 with HTTP; Mon, 14 Mar 2016 09:34:47 -0700 (PDT)
In-Reply-To: <egbd-82yi-wny@vfemail.net>
References: <201603140439.u2E4dZNO096916@repo.freebsd.org>
 <egbd-82yi-wny@vfemail.net>
Date: Mon, 14 Mar 2016 09:34:47 -0700
X-Google-Sender-Auth: 0Ilqj_43UMlJkmpijys9phglFEY
Message-ID: <CAJ-VmomnEq2mh5cwHXue1rb0QLxvyL_sz=t2KEOJUzE6eYaC_w@mail.gmail.com>
Subject: Re: svn commit: r296823 - in head: sbin/ifconfig sys/net80211
From: Adrian Chadd <adrian@freebsd.org>
To: Jan Beich <jbeich@freebsd.org>
Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, 
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, 
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Content-Type: text/plain; charset=UTF-8
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Mar 2016 16:34:48 -0000

oops! I'll fix now

Thanks!


-a


On 14 March 2016 at 09:00, Jan Beich <jbeich@freebsd.org> wrote:
> Adrian Chadd <adrian@FreeBSD.org> writes:
>
>> Author: adrian
>> Date: Mon Mar 14 04:39:35 2016
>> New Revision: 296823
>> URL: https://svnweb.freebsd.org/changeset/base/296823
>>
>> Log:
>>   [net80211] handle unlisted information elements.
>>
>>   This displays the IE names in ifconfig but it doesn't yet decode things.
>>
>>   Submitted by: Idwer Vollering <vidwer@gmail.com>
>>   Differential Revision:      https://reviews.freebsd.org/D3782
> [...]
>> Modified: head/sys/net80211/ieee80211.h
> [...]
>> +struct ieee80211_ap_chan_report_ie {
>> +     uint8_t         ie;
>> +     uint8_t         len;
>> +     uint8_t         class; /* operating class */
>
> "class" is a reserved keyword in C++. www/firefox implements wifi
> geolocation in C++, so it's now broken. www/chromium is probably also
> affected.
>
>   In file included from netwerk/wifi/Unified_cpp_netwerk_wifi0.cpp:20:
>   In file included from netwerk/wifi/nsWifiScannerFreeBSD.cpp:19:
>   In file included from /usr/include/net80211/ieee80211_ioctl.h:35:
>   /usr/include/net80211/ieee80211.h:800:11: error: declaration of anonymous class must be a definition
>           uint8_t         class; /* operating class */
>                           ^
>   1 error generated.