From owner-svn-ports-head@freebsd.org  Wed Apr 24 06:17:54 2019
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 16723158DE70;
 Wed, 24 Apr 2019 06:17:54 +0000 (UTC)
 (envelope-from leres@freebsd.org)
Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id AE68D75838;
 Wed, 24 Apr 2019 06:17:53 +0000 (UTC)
 (envelope-from leres@freebsd.org)
Received: from [IPv6:fd:1965::64] (unknown
 [IPv6:2001:558:6045:10:9084:9e0:4b6d:eb99])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client did not present a certificate) (Authenticated sender: leres)
 by smtp.freebsd.org (Postfix) with ESMTPSA id 11F4328986;
 Wed, 24 Apr 2019 06:17:52 +0000 (UTC)
 (envelope-from leres@freebsd.org)
Subject: Re: svn commit: r499246 - head/security/libssh2
To: Steve Wills <swills@FreeBSD.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
References: <201904181037.x3IAbCEp040415@repo.freebsd.org>
From: Craig Leres <leres@freebsd.org>
Message-ID: <ab309aeb-f31c-1afb-92ef-e04666ae9060@freebsd.org>
Date: Tue, 23 Apr 2019 23:17:49 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <201904181037.x3IAbCEp040415@repo.freebsd.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Rspamd-Queue-Id: AE68D75838
X-Spamd-Bar: --
Authentication-Results: mx1.freebsd.org
X-Spamd-Result: default: False [-2.94 / 15.00];
 local_wl_from(0.00)[freebsd.org];
 NEURAL_HAM_MEDIUM(-1.00)[-0.999,0];
 NEURAL_HAM_SHORT(-0.94)[-0.939,0];
 ASN(0.00)[asn:11403, ipnet:96.47.64.0/20, country:US];
 NEURAL_HAM_LONG(-1.00)[-1.000,0]
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Apr 2019 06:17:54 -0000

On 4/18/2019 3:37 AM, Steve Wills wrote:
> Author: swills
> Date: Thu Apr 18 10:37:12 2019
> New Revision: 499246
> URL: https://svnweb.freebsd.org/changeset/ports/499246
> 
> Log:
>   security/libssh2: update to 1.8.1
>   
>   PR:		236711
>   Submitted by:	Leonid Nevecherya <nevecherya@gmail.com>
>   Approved by:	sbz (maintainer)
>   MFH:		2019Q2
>   Security:	6e58e1e9-2636-413e-9f84-4c0e21143628

This breaks libssh2_userauth_publickey_fromfile() for me. While
debugging I discovered 1.8.2 was released on March 25 with a fix for
this issue:

    https://www.libssh2.org/changes.html

    Bug fixes:

	- Fixed the misapplied userauth patch that broke 1.8.1
	- moved the MAX size declarations from the public header

Could we update to 1.8.2? I'm also happy to file a PR if you'd prefer that.

		Craig