From owner-svn-src-all@freebsd.org Fri Feb 21 00:42:04 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6A15B24BAE4; Fri, 21 Feb 2020 00:42:04 +0000 (UTC) (envelope-from mmatsuda@cybernet.co.jp) Received: from mo-csw.securemx.jp (mo-csw1116.securemx.jp [210.130.202.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 48Nt2K4HdLz4VLc; Fri, 21 Feb 2020 00:42:00 +0000 (UTC) (envelope-from mmatsuda@cybernet.co.jp) Received: by mo-csw.securemx.jp (mx-mo-csw1116) id 01L0fsHC015067; Fri, 21 Feb 2020 09:41:55 +0900 X-Iguazu-Qid: 2wGrUl5MbUArmwQe1I X-Iguazu-QSIG: v=2; s=0; t=1582245714; q=2wGrUl5MbUArmwQe1I; m=0vclltx05SbWq4+Ng9yj8DMyWg0ZeT+77sxBRUi8P+0= Received: from rism-57d.kgt.cybernet.co.jp (posh.kgt.cybernet.co.jp [202.214.241.90]) by relay.securemx.jp (mx-mr1111) id 01L0frZE013738; Fri, 21 Feb 2020 09:41:53 +0900 Received: from localhost (kgtm-85d.kgt.cybernet.co.jp [10.21.35.22]) by rism-57d.kgt.cybernet.co.jp (Postfix) with ESMTP id 657ABDD89D1; Fri, 21 Feb 2020 09:41:53 +0900 (JST) Date: Fri, 21 Feb 2020 09:41:31 +0900 (JST) Message-Id: <20200221.094131.01367154.mmatsuda@cybernet.co.jp> To: jeff@FreeBSD.org Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r358097 - in head/sys: kern vm From: mmatsuda@cybernet.co.jp In-Reply-To: <202002190817.01J8HRTY062438@repo.freebsd.org> References: <202002190817.01J8HRTY062438@repo.freebsd.org> X-Mailer: Mew version 4.2 on Emacs 21.4 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 48Nt2K4HdLz4VLc X-Spamd-Bar: + X-Spamd-Result: default: False [1.03 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.44)[-0.439,0]; R_DKIM_ALLOW(-0.20)[cybernet.co.jp:s=20190225.smx]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:210.130.202.152/29]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; MV_CASE(0.50)[]; RCVD_COUNT_THREE(0.00)[4]; IP_SCORE(0.83)[ipnet: 210.130.0.0/16(2.51), asn: 2497(1.59), country: JP(0.04)]; DKIM_TRACE(0.00)[cybernet.co.jp:+]; DMARC_POLICY_ALLOW(-0.50)[cybernet.co.jp,quarantine]; FROM_NO_DN(0.00)[]; MID_CONTAINS_FROM(1.00)[]; NEURAL_SPAM_LONG(0.24)[0.241,0]; RCVD_IN_DNSWL_LOW(-0.10)[158.202.130.210.list.dnswl.org : 127.0.5.1]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:2497, ipnet:210.130.0.0/16, country:JP]; RCVD_TLS_LAST(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Feb 2020 00:42:04 -0000 Hi Jeff, From: Jeff Roberson Date: Wed, 19 Feb 2020 08:17:27 +0000 (UTC) >Author: jeff >Date: Wed Feb 19 08:17:27 2020 >New Revision: 358097 >URL: https://svnweb.freebsd.org/changeset/base/358097 > >Log: > Eliminate some unnecessary uses of UMA_ZONE_VM. Only zones involved in > virtual address or physical page allocation need to be marked with this > flag. > > Reviewed by: markj > Tested by: pho > Differential Revision: https://reviews.freebsd.org/D23712 > >Modified: > head/sys/kern/subr_vmem.c > head/sys/kern/vfs_subr.c > head/sys/vm/swap_pager.c > head/sys/vm/vm_page.c > head/sys/vm/vm_pager.c > >Modified: head/sys/kern/subr_vmem.c >============================================================================== >--- head/sys/kern/subr_vmem.c Wed Feb 19 08:15:20 2020 (r358096) >+++ head/sys/kern/subr_vmem.c Wed Feb 19 08:17:27 2020 (r358097) >@@ -561,8 +561,7 @@ qc_init(vmem_t *vm, vmem_size_t qcache_max) > qc->qc_vmem = vm; > qc->qc_size = size; > qc->qc_cache = uma_zcache_create(qc->qc_name, size, >- NULL, NULL, NULL, NULL, qc_import, qc_release, qc, >- UMA_ZONE_VM); >+ NULL, NULL, NULL, NULL, qc_import, qc_release, qc, 0); > MPASS(qc->qc_cache); > } > } >@@ -668,10 +667,10 @@ vmem_startup(void) > mtx_init(&vmem_list_lock, "vmem list lock", NULL, MTX_DEF); > vmem_zone = uma_zcreate("vmem", > sizeof(struct vmem), NULL, NULL, NULL, NULL, >- UMA_ALIGN_PTR, UMA_ZONE_VM); >+ UMA_ALIGN_PTR, 0); > vmem_bt_zone = uma_zcreate("vmem btag", > sizeof(struct vmem_btag), NULL, NULL, NULL, NULL, >- UMA_ALIGN_PTR, UMA_ZONE_VM | UMA_ZONE_NOFREE); >+ UMA_ALIGN_PTR, UMA_ZONE_VM); If I'm reading the message correctly, shouldn't the above line be like the following? + UMA_ALIGN_PTR, UMA_ZONE_NOFREE); Regards, Haro =----------------------------------------------------------------------- _ _ Munehiro (haro) Matsuda -|- /_\ |_|_| Cybernet Systems Co., Ltd. /|\ |_| |_|_|