From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Aug 8 07:30:28 2006 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F101F16A4DA for ; Tue, 8 Aug 2006 07:30:28 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id E8F0C43D46 for ; Tue, 8 Aug 2006 07:30:15 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k787UFUV041099 for ; Tue, 8 Aug 2006 07:30:15 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k787UFc1041097; Tue, 8 Aug 2006 07:30:15 GMT (envelope-from gnats) Resent-Date: Tue, 8 Aug 2006 07:30:15 GMT Resent-Message-Id: <200608080730.k787UFc1041097@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Philip M. Gollucci" Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 48C8916A4DD for ; Tue, 8 Aug 2006 07:22:37 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id 836EA43D6B for ; Tue, 8 Aug 2006 07:22:36 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k787MaVP020066 for ; Tue, 8 Aug 2006 07:22:36 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id k787MaDB020064; Tue, 8 Aug 2006 07:22:36 GMT (envelope-from nobody) Message-Id: <200608080722.k787MaDB020064@www.freebsd.org> Date: Tue, 8 Aug 2006 07:22:36 GMT From: "Philip M. Gollucci" To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Cc: Subject: ports/101639: Update: www/p5-Apache-Peek 1.02 -> 1.06, unbreak mp2 builds, request maintainership X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Aug 2006 07:30:29 -0000 >Number: 101639 >Category: ports >Synopsis: Update: www/p5-Apache-Peek 1.02 -> 1.06, unbreak mp2 builds, request maintainership >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Tue Aug 08 07:30:15 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Philip M. Gollucci >Release: 6.1-stable >Organization: P6M7G8 Consulting >Environment: FreeBSD home.p6m7g8.net 6.1-STABLE FreeBSD 6.1-STABLE #0: Mon Jul 3 23:24:44 PDT 2006 pgollucci@home.p6m7g8.net:/usr/obj/usr/src/sys/HOME i386 >Description: Depends on: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/101636 Obsolete/Superceeds http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/84143 From Skv: 3. I don't like hack with INC overriding. I suppose ModPerl::MM must be patched to support correct set of -I dirs. Too much modules are depended on mod_perl2 hence such "-I" workaround must be applied to mod_perl2 port. I did patch this as feed back to 84143, but was never comitted. That particular patch no longer works as www/apache22 is now a choice too, if you so desire I could craft another patch for this. I; however, with my mod_perl PMC hat on, do not particular like this idea. This passes portlint -A except for this FATAL: breaks INDEX ([: -le: argument expected [: -le: argument expected p5-Apache-Peek-1.06: "/usr/ports/apache20" non-existent -- dependency list incomplete). 1 fatal errors and 0 warnings found. This is caused by the inclusion of USE_APACHE=x and is not unique to this port any any apache version. I've tested this port with lang/perl5.8 www/apache13 + www/mod_perl www/apache20 + www/mod_perl2 www/apache22 + www/mod_perl2 >How-To-Repeat: >Fix: Index: Makefile =================================================================== RCS file: /home/ncvs/ports/www/p5-Apache-Peek/Makefile,v retrieving revision 1.12 diff -u -r1.12 Makefile --- Makefile 17 May 2005 17:18:22 -0000 1.12 +++ Makefile 8 Aug 2006 07:12:49 -0000 @@ -2,34 +2,38 @@ # Date created: 24-Jul-2000 # Whom: Leo Kim # -# $FreeBSD: ports/www/p5-Apache-Peek/Makefile,v 1.12 2005/05/17 17:18:22 sem Exp $ +# $FreeBSD$ # PORTNAME= Apache-Peek -PORTVERSION= 1.02 +PORTVERSION= 1.06 CATEGORIES= www perl5 MASTER_SITES= ${MASTER_SITE_PERL_CPAN} -MASTER_SITE_SUBDIR= ../../authors/id/S/ST/STAS +MASTER_SITE_SUBDIR= Apache PKGNAMEPREFIX= p5- -MAINTAINER= skv@FreeBSD.org +MAINTAINER= pgollucci@p6m7g8.com COMMENT= A data debugging tool for the XS programmer (under mod_perl) .if defined(WITH_MODPERL2) -BROKEN= Broken due the new mod_perl2 API -BUILD_DEPENDS= ${SITE_PERL}/${PERL_ARCH}/Apache2/mod_perl.pm:${PORTSDIR}/www/mod_perl2 -MOD_PERL= 2 +BUILD_DEPENDS= ${SITE_PERL}/${PERL_ARCH}/mod_perl2.pm:${PORTSDIR}/www/mod_perl2 .else BUILD_DEPENDS= ${SITE_PERL}/${PERL_ARCH}/mod_perl.pm:${PORTSDIR}/www/mod_perl \ - ${SITE_PERL}/${PERL_ARCH}/Apache/Test.pm:${PORTSDIR}/www/p5-Apache-Test -MOD_PERL= 1 + ${SITE_PERL}/${PERL_ARCH}/Apache/Test.pm:${PORTSDIR}/www/p5-Apache-Test .endif -PERL_CONFIGURE= YES +## this is intentionally outside the above if because of portlint +.if defined(WITH_MODPERL2) +MODPERL= 2 +.else +MODPERL= 1 +.endif -CONFIGURE_ARGS= -httpd ${LOCALBASE}/sbin/httpd +USE_APACHE= 1.3+ -MAN3= Apache::Peek.3 +PERL_CONFIGURE= YES + +CONFIGURE_ARGS= MOD_PERL=${MOD_PERL} -httpd ${LOCALBASE}/sbin/httpd .include @@ -37,9 +41,19 @@ BUILD_DEPENDS+= ${SITE_PERL}/${PERL_ARCH}/Devel/Peek.pm:${PORTSDIR}/devel/p5-Devel-Peek .endif -RUN_DEPENDS= ${BUILD_DEPENDS} +.if defined(WITH_MODPERL2) +INC=-I${LOCALBASE}/${APACHEINCLUDEDIR} \ + -I${LOCALBASE}/${APACHEINCLUDEDIR}/modules \ + -I${LOCALBASE}/${APACHEINCLUDEDIR}/modules/perl + +.if ${APACHE_VERSION} == 22 +INC+=-I${LOCALBASE}/include/apr-1 +.endif + +CONFIGURE_ARGS+='INC=${INC}' -post-patch: - @${PERL} -pi -e '$$_="" if /^test_configure\(/;' ${WRKSRC}/Makefile.PL +.endif + +MAN3= Apache::Peek.3 .include Index: distinfo =================================================================== RCS file: /home/ncvs/ports/www/p5-Apache-Peek/distinfo,v retrieving revision 1.4 diff -u -r1.4 distinfo --- distinfo 24 Jan 2006 03:13:40 -0000 1.4 +++ distinfo 8 Aug 2006 07:12:49 -0000 @@ -1,3 +1,3 @@ -MD5 (Apache-Peek-1.02.tar.gz) = 160f9c78fcf6d7d034ce83bf7b4c118b -SHA256 (Apache-Peek-1.02.tar.gz) = 6bbce1d04d492c08f5ccaa9af2948ee78793b7ce3c089782a7d3cffd794e43f9 -SIZE (Apache-Peek-1.02.tar.gz) = 23500 +MD5 (Apache-Peek-1.06.tar.gz) = c1e028bbd61ba01b8e48035466b39feb +SHA256 (Apache-Peek-1.06.tar.gz) = 1b64ef67d69225602b34ea29de4613b7210d7808e36786b5ec99d7f7e70bbf86 +SIZE (Apache-Peek-1.06.tar.gz) = 49865 >Release-Note: >Audit-Trail: >Unformatted: