From owner-svn-src-all@freebsd.org Thu Dec 22 20:58:00 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 215BAC8D701; Thu, 22 Dec 2016 20:58:00 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-it0-x241.google.com (mail-it0-x241.google.com [IPv6:2607:f8b0:4001:c0b::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DABDA10A9; Thu, 22 Dec 2016 20:57:59 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-it0-x241.google.com with SMTP id 75so22155208ite.1; Thu, 22 Dec 2016 12:57:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=PVB9KJGh5Wbdjqs4OQvpwhhJ8sJHWWMLBMljR7+9E28=; b=Zn5nEnJKQUwjswkLRAkz+Lq6leyTw7AK+2hpvKwFhRwZ2XiIxwBU4i2/ok1ywYFFdc EywbFvLHHm9uD5i86t1SzYZtE1+fxlYH2wxfx0cwvTi3DyPpFTBuVNtT42dAWqU2mZDz nYVvzFbbhey15WEdwvu6OG4NjhV24/rirVWcZbwippcgS9ivKPLj3H3sQ55iPTKyYmIz HiY6QxHJxlPbZB7uUh2i6f5Ba25u7Oeb8BoK/PYxZzTKlfX0zpvSz7XRGEHJeV7YiMkZ AdNcCsDLCDMyncMP9ZrQzjCv1L7Wq4jTUODiKGjnFQrCdLTfusFaHUVKy2veqyJ+YdJk APjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=PVB9KJGh5Wbdjqs4OQvpwhhJ8sJHWWMLBMljR7+9E28=; b=ufzKc3Ucep+TEpwujpDRsxxF5381bVTKf1vRTsIMWBPW5DFP0ZobbEASL8zfdOI+V8 CQFs5pOo54JGzn3QkdXdMuCCi0Hn1uGUbgkqcbDnZ5ntTfhDNpszYqCjv4ccK0mOYPm0 hKyXuvGpEl/eWDN0XuNtSI3HcDGI7MZ6FKcFPzpEX1ufgSkc3OjhPPvqjSsJSxWtxYSJ t6QmzVEPRHWPzWozuqot/lbpkf1hhpjQ683YuuMV1Hedby4u1YIfms1VMRqrbSv6hOBL YFVopCXun74Hkol/kyfkft7a/Mxjba+WWc2O7cadGVUM3vC+4EYWOqb7itBieElMCseD EBLg== X-Gm-Message-State: AIkVDXLjaTQtOGmgoQWYPKq2oGKUhol5Z3PgveR9IkF4nlFzdUv5sJK3tUbsgQgcWsToXjCVMBv/axcPw6I/fw== X-Received: by 10.36.108.17 with SMTP id w17mr10919103itb.108.1482440279381; Thu, 22 Dec 2016 12:57:59 -0800 (PST) MIME-Version: 1.0 Sender: carpeddiem@gmail.com Received: by 10.107.175.133 with HTTP; Thu, 22 Dec 2016 12:57:38 -0800 (PST) In-Reply-To: References: <201612221826.uBMIQLFQ076247@repo.freebsd.org> From: Ed Maste Date: Thu, 22 Dec 2016 15:57:38 -0500 X-Google-Sender-Auth: ZwTEFqFcPnM_izyqToo7yTj8szA Message-ID: Subject: Re: svn commit: r310425 - in head/sys/dev/mlx4: mlx4_core mlx4_ib To: Ed Schouten Cc: src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Dec 2016 20:58:00 -0000 On 22 December 2016 at 14:44, Ed Schouten wrote: > 2016-12-22 19:26 GMT+01:00 Ed Maste : >> Log: >> mlx: avoid use of __DATE__ to make build reproducible > > Out of curiosity, are we planning on adding -Wdate-time or > -Werror=date-time to our default CFLAGS? If so, awesome! I hadn't thought of it, but good idea. Maybe something like this for now: --- a/share/mk/bsd.sys.mk +++ b/share/mk/bsd.sys.mk @@ -88,6 +88,9 @@ CWARNFLAGS.clang+= -Wno-parentheses .if defined(NO_WARRAY_BOUNDS) CWARNFLAGS.clang+= -Wno-array-bounds .endif # NO_WARRAY_BOUNDS +.if ${MK_REPRODUCIBLE_BUILD} != no +CWARNFLAGS.clang+= -Wdate-time +.endif # MK_REPRODUCIBLE_BUILD .endif # WARNS