From owner-cvs-all Sat Apr 20 7:54:50 2002 Delivered-To: cvs-all@freebsd.org Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by hub.freebsd.org (Postfix) with ESMTP id 24AD737B417; Sat, 20 Apr 2002 07:54:40 -0700 (PDT) Received: from pobrecita.freebsd.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.12.2/8.12.2) with ESMTP id g3KEsbiJ005597; Sat, 20 Apr 2002 18:54:39 +0400 (MSD) (envelope-from ache@pobrecita.freebsd.ru) Received: (from ache@localhost) by pobrecita.freebsd.ru (8.12.3/8.12.2/Submit) id g3KEsbnB005596; Sat, 20 Apr 2002 18:54:37 +0400 (MSD) Date: Sat, 20 Apr 2002 18:54:37 +0400 From: "Andrey A. Chernov" To: Robert Watson Cc: "Jacques A. Vidrine" , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/crypto/openssh servconf.c session.c Message-ID: <20020420145437.GB5350@nagual.pp.ru> References: <20020420143525.GB27108@madman.nectar.cc> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.28i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat, Apr 20, 2002 at 10:46:22 -0400, Robert Watson wrote: > > On Sat, 20 Apr 2002, Jacques A. Vidrine wrote: > > > On Sat, Apr 20, 2002 at 02:26:44AM -0700, Andrey A. Chernov wrote: > > > 1) Surprisingly, "CheckMail" handling code completely removed from this > > > version, so documented "CheckMail" option exists but does nothing. > > > Bring it back to life adding code back. > > > > Why not just finish killing it? > > Yeah, personally I'd prefer we avoid introducing gratuitous diffs against > the OpenSSH source -- some changes are necessary (PAM, et al), but > anything beyond the base necessary changes just makes updating more of a > pain. We've already had updates stalled by >6-8 months because of many > local changes, so that's a problem we need to be very careful to avoid. Please note that "CheckMail" was in OpenSSH since long time and was removed just recently, making lack of "login" look & feel without any reason. Moreover, old "ssh" (pre-OpenSSH) check mail too without any option, like "login" does. Users really want to know they have new mail when they logged in! About setusercontext() changes: they are absolutely necessary, if we support login.conf. We can either remove them with whole login.conf support (why we have login.conf so?) or do it correctly. We can't live with half-singing half-dancing old variant, I mean broken login.conf support. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message