Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 10 Jul 2020 11:01:31 +0200
From:      Peter Holm <pho@freebsd.org>
To:        Mateusz Guzik <mjg@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r363069 - head/sys/kern
Message-ID:  <20200710090131.GA34716@x8.osted.lan>
In-Reply-To: <202007100647.06A6lwCE015392@repo.freebsd.org>
References:  <202007100647.06A6lwCE015392@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jul 10, 2020 at 06:47:58AM +0000, Mateusz Guzik wrote:
> Author: mjg
> Date: Fri Jul 10 06:47:58 2020
> New Revision: 363069
> URL: https://svnweb.freebsd.org/changeset/base/363069
> 
> Log:
>   vfs: depessimize getfsstat when only the count is requested
>   
>   This avoids relocking mountlist_mtx for each entry.
> 
> Modified:
>   head/sys/kern/vfs_syscalls.c
> 
> Modified: head/sys/kern/vfs_syscalls.c
> ==============================================================================
> --- head/sys/kern/vfs_syscalls.c	Fri Jul 10 06:46:42 2020	(r363068)

Could this one be yours?

20200710 09:46:31 all (267/723): procfs.sh
panic: lock (sleep mutex) mountlist not locked @ kern/vfs_syscalls.c:561
cpuid = 4
time = 1594367192
KDB: stack backtrace:
db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe00377a6910
vpanic() at vpanic+0x182/frame 0xfffffe00377a6960
panic() at panic+0x43/frame 0xfffffe00377a69c0
witness_unlock() at witness_unlock+0x147/frame 0xfffffe00377a6a00
__mtx_unlock_flags() at __mtx_unlock_flags+0x4d/frame 0xfffffe00377a6a30
kern_getfsstat() at kern_getfsstat+0x40b/frame 0xfffffe00377a6ab0
sys_getfsstat() at sys_getfsstat+0x22/frame 0xfffffe00377a6ad0
amd64_syscall() at amd64_syscall+0x159/frame 0xfffffe00377a6bf0
fast_syscall_common() at fast_syscall_common+0x101/frame 0xfffffe00377a6bf0
--- syscall (557, FreeBSD ELF64, sys_getfsstat), rip = 0x80032db1a, rsp = 0x7fffffffd738, rbp = 0x7fffffffd790 ---
KDB: enter: panic

https://people.freebsd.org/~pho/stress/log/mjguzik030.txt

- Peter



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200710090131.GA34716>