From owner-freebsd-arch Wed Mar 14 20:29:46 2001 Delivered-To: freebsd-arch@freebsd.org Received: from smtp05.primenet.com (smtp05.primenet.com [206.165.6.135]) by hub.freebsd.org (Postfix) with ESMTP id C151637B719 for ; Wed, 14 Mar 2001 20:29:43 -0800 (PST) (envelope-from tlambert@usr05.primenet.com) Received: (from daemon@localhost) by smtp05.primenet.com (8.9.3/8.9.3) id VAA00394; Wed, 14 Mar 2001 21:24:08 -0700 (MST) Received: from usr05.primenet.com(206.165.6.205) via SMTP by smtp05.primenet.com, id smtpdAAA3RaWNa; Wed Mar 14 21:23:54 2001 Received: (from tlambert@localhost) by usr05.primenet.com (8.8.5/8.8.5) id VAA00913; Wed, 14 Mar 2001 21:29:21 -0700 (MST) From: Terry Lambert Message-Id: <200103150429.VAA00913@usr05.primenet.com> Subject: Re: [PATCH] add a SITE MD5 command to ftpd To: nate@yogotech.com Date: Thu, 15 Mar 2001 04:29:21 +0000 (GMT) Cc: tlambert@primenet.com (Terry Lambert), dnelson@emsphone.com (Dan Nelson), des@ofug.org (Dag-Erling Smorgrav), freebsd-arch@FreeBSD.ORG In-Reply-To: <15024.1726.752945.368097@nomad.yogotech.com> from "Nate Williams" at Mar 14, 2001 05:03:10 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > > Remember that the only thing this is useful for is files that > > change without changing the filename (e.g. no version number > > in the name, etc.). > > > > I'd argue that that was pretty rare. > > It happens *alot*, if you follow the commit messages. What percentage of ports have been hit by this, according to the commit logs? In my experience, it's much more likely for the file to not be on any of the servers, like the ghostscript6 port in the 4.2 release. A better question might be "how many times has it happened, and the patches still applied successfully, after you made the !$%@! port ignore the MD5 checksum?"... So... is the FreeBSD FTP server going to have this "feature" added to it, or is DG putting his foot down? I still think the SIZE is an OK think; if everyone is in love with the SITE MD5 thing, at least make it so it will prefer the contents of a "site.md5" file in the directory to doing recomputation, or, even better, will cache MD5, filename, and timestamp, look at the timestamp for the name, or if the name doesn't exist, MD5 it, and cache the new value, and if the timestamp is equal, return the cached value. Even a cron job is a lot better than calculating an MD5 5000 times on the same file... Terry Lambert terry@lambert.org --- Any opinions in this posting are my own and not those of my present or previous employers. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message