From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Dec 8 17:10:21 2006 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6537816A4A7 for ; Fri, 8 Dec 2006 17:10:21 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.FreeBSD.org (Postfix) with ESMTP id F3A8243CAE for ; Fri, 8 Dec 2006 17:09:18 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id kB8HAH0h002837 for ; Fri, 8 Dec 2006 17:10:17 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id kB8HAHqu002836; Fri, 8 Dec 2006 17:10:17 GMT (envelope-from gnats) Resent-Date: Fri, 8 Dec 2006 17:10:17 GMT Resent-Message-Id: <200612081710.kB8HAHqu002836@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Rong-En Fan Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 995B316A47B; Fri, 8 Dec 2006 17:01:49 +0000 (UTC) (envelope-from rafan@svm.csie.ntu.edu.tw) Received: from svm.csie.ntu.edu.tw (svm.csie.ntu.edu.tw [140.112.90.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6589343CA6; Fri, 8 Dec 2006 17:00:48 +0000 (GMT) (envelope-from rafan@svm.csie.ntu.edu.tw) Received: from svm.csie.ntu.edu.tw (localhost [127.0.0.1]) by svm.csie.ntu.edu.tw (8.13.8/8.13.8) with ESMTP id kB8H1kMD085674; Sat, 9 Dec 2006 01:01:46 +0800 (CST) (envelope-from rafan@svm.csie.ntu.edu.tw) Received: (from rafan@localhost) by svm.csie.ntu.edu.tw (8.13.8/8.13.8/Submit) id kB8H1kFr090245; Sat, 9 Dec 2006 01:01:46 +0800 (CST) (envelope-from rafan) Message-Id: <200612081701.kB8H1kFr090245@svm.csie.ntu.edu.tw> Date: Sat, 9 Dec 2006 01:01:46 +0800 (CST) From: Rong-En Fan To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: kde@FreeBSD.org Subject: ports/106486: [PATCH] pass correct QTDIR/KDEDIR in bsd.kde.mk X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Rong-En Fan List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Dec 2006 17:10:21 -0000 >Number: 106486 >Category: ports >Synopsis: [PATCH] pass correct QTDIR/KDEDIR in bsd.kde.mk >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Fri Dec 08 17:10:17 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Rong-En Fan >Release: FreeBSD 6.2-PRERELEASE amd64 >Organization: NTU CSIE >Environment: >Description: QTDIR/KDEDIR is not passwd when USE_QT_VER != CVS. When X11BASE sets to a non-standard, say /usr/X11R6, value, some ports fail to build: devel/libchipcard-kde graphics/djvulibre graphics/gephex irc/kvirc net-p2p/dctc-gui-qt I fixed some of them by passing QTDIR. However, fixing this in bsd.kde.mk is much better. Moreover, we can clean up some ports that manually set QTDIR. I tested this patch with the five ports mentioned above in tinderbox. All build fine. >How-To-Repeat: >Fix: Index: bsd.kde.mk =================================================================== RCS file: /home/pcvs/ports/Mk/bsd.kde.mk,v retrieving revision 1.63 diff -u -r1.63 bsd.kde.mk --- bsd.kde.mk 12 Sep 2006 23:26:10 -0000 1.63 +++ bsd.kde.mk 8 Dec 2006 16:47:49 -0000 @@ -125,7 +125,8 @@ --with-qt-libraries=${QT_PREFIX}/lib \ --with-extra-libs=${LOCALBASE}/lib \ --with-extra-includes=${LOCALBASE}/include -CONFIGURE_ENV+= MOC="${MOC}" CPPFLAGS="${CPPFLAGS} ${QTCPPFLAGS}" LIBS="${QTCFGLIBS}" +CONFIGURE_ENV+= MOC="${MOC}" CPPFLAGS="${CPPFLAGS} ${QTCPPFLAGS}" LIBS="${QTCFGLIBS}" \ + QTDIR="${QT_PREFIX}" KDEDIR="${KDE_PREFIX}" .endif # !defined(QT_NONSTANDARD) .else IGNORE= cannot install: unsupported value of USE_QT_VER >Release-Note: >Audit-Trail: >Unformatted: