From owner-freebsd-fs@FreeBSD.ORG  Thu Jun  7 12:55:33 2012
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E719E106566B;
	Thu,  7 Jun 2012 12:55:33 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net
	[IPv6:2001:470:1f10:75::2])
	by mx1.freebsd.org (Postfix) with ESMTP id BB0A28FC16;
	Thu,  7 Jun 2012 12:55:33 +0000 (UTC)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
	by bigwig.baldwin.cx (Postfix) with ESMTPSA id 3C949B977;
	Thu,  7 Jun 2012 08:55:33 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Konstantin Belousov <kostikbel@gmail.com>
Date: Thu, 7 Jun 2012 08:41:00 -0400
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p13; KDE/4.5.5; amd64; ; )
References: <201203071318.08241.jhb@freebsd.org>
	<201206060817.54684.jhb@freebsd.org>
	<20120606183949.GR85127@deviant.kiev.zoral.com.ua>
In-Reply-To: <20120606183949.GR85127@deviant.kiev.zoral.com.ua>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201206070841.00656.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
	(bigwig.baldwin.cx); Thu, 07 Jun 2012 08:55:33 -0400 (EDT)
Cc: freebsd-fs@freebsd.org, pho@freebsd.org
Subject: Re: close() of an flock'd file is not atomic
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Jun 2012 12:55:34 -0000

On Wednesday, June 06, 2012 2:39:49 pm Konstantin Belousov wrote:
> On Wed, Jun 06, 2012 at 08:17:54AM -0400, John Baldwin wrote:
> > Based on feedback from Konstantin, I have split the vn_open_vnode() changes
> > out into a separate patch.  Once that patch is in the tree I will revisit
> > this and update the actual bug-fix patch.
> > 
> > The vn_open_vnode() patch is at
> > http://www.freebsd.org/~jhb/patches/vn_open_vnode.patch
> > 
> > I tested it by doing a buildworld -j 32 in a loop while NFS exporting the
> > /usr/obj tree to another machine that did a continual find | xargs md5 loop
> > over the /usr/obj tree.  This survived overnight.
> 
> There is #if 0 left in fhopen() which translates ERESTART into EINTR. Is
> it needed ?

Bruce's reply makes me think it is not, so I will remove it.

> Otherwise it looks fine (but still quite hard to read).

I agree the diff is hard to parse.  Hopefully the patched code itself is
easier to read than the previous version.

-- 
John Baldwin