From owner-freebsd-fs@FreeBSD.ORG Fri Apr 27 09:06:19 2012 Return-Path: Delivered-To: freebsd-fs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 790D71065673; Fri, 27 Apr 2012 09:06:19 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 8F1F38FC1B; Fri, 27 Apr 2012 09:06:18 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id MAA05215; Fri, 27 Apr 2012 12:06:14 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1SNh81-0007Wn-VU; Fri, 27 Apr 2012 12:06:14 +0300 Message-ID: <4F9A6180.8090500@FreeBSD.org> Date: Fri, 27 Apr 2012 12:06:08 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:12.0) Gecko/20120425 Thunderbird/12.0 MIME-Version: 1.0 To: Marius Strobl References: <4F8999D2.1080902@FreeBSD.org> <20120422212102.GA66855@alchemy.franken.de> In-Reply-To: <20120422212102.GA66855@alchemy.franken.de> X-Enigmail-Version: 1.4 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-fs@FreeBSD.org, freebsd-hackers@FreeBSD.org Subject: Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Apr 2012 09:06:19 -0000 on 23/04/2012 00:21 Marius Strobl said the following: > On Sat, Apr 14, 2012 at 06:37:54PM +0300, Andriy Gapon wrote: [snip] >> I am particularly interested in reviews of my attempt to make ZFS boot support >> arch-independent. The arches, of course, would have to add some code to make >> use of that support. Currently I only enabled it for x86. >> > > I can't say much about these patches as a whole as they are rather > big and I'm not aware of all the details of ZFS. However, one bit that > makes the current implementation x86-specific is zfs_dev_init(). If > you could move it to the MD part in the course of these patches that > would be great. I have arranged this in my WIP version of the patch, which I hope to share soon. Need to work out some unrelated details. > If you could also take the second patch in PR 165025 > into account, which I plan to commit once the issue with the current > ofw_disk.c are properly solved, that would be great. Thank you for the heads up. Since I also hope to commit my patch rather soon, I would also appreciate if you keep my changes in mind :-) In fact, I would like to ask you if it would make sense to postpone the patch from the PR until my patch is committed. That should make some things easier to do (e.g. MD zfs_dev_init), but on the other hand some things would become different. Either way, one of the patches would have to be rebased on top of the other. -- Andriy Gapon