Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 31 Aug 2019 17:29:54 -0600
From:      Warner Losh <imp@bsdimp.com>
To:        "Conrad E. Meyer" <cem@freebsd.org>
Cc:        Li-Wen Hsu <lwhsu@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org>
Subject:   Re: svn commit: r351643 - in head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common: dtraceUtil speculation
Message-ID:  <CANCZdfrbwO%2BW7zVH6%2B=Jr09jONyqMnoT7ejavCh%2BNopBvcuyHg@mail.gmail.com>
In-Reply-To: <CAG6CVpVf%2BY5uABKsJhS2LubT6BnmWmeMWF7M0HN1n4eQdZW6fg@mail.gmail.com>
References:  <201908311441.x7VEfwZ3045957@repo.freebsd.org> <CAG6CVpVf%2BY5uABKsJhS2LubT6BnmWmeMWF7M0HN1n4eQdZW6fg@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Aug 31, 2019 at 5:29 PM Conrad Meyer <cem@freebsd.org> wrote:

> Thanks Li-Wen!  Might it be less fragile to have the test fixture
> create a file, if the test(s) will expect one to be present to read?
>

Or just use the realpath $0, which you know has to exist :)

Warner


> On Sat, Aug 31, 2019 at 7:42 AM Li-Wen Hsu <lwhsu@freebsd.org> wrote:
> >
> > Author: lwhsu
> > Date: Sat Aug 31 14:41:58 2019
> > New Revision: 351643
> > URL: https://svnweb.freebsd.org/changeset/base/351643
> >
> > Log:
> >   Fix tests use /etc/motd after r350184 by using an always existing file
> >
> >   Sponsored by: The FreeBSD Foundation
> >
> > Modified:
> >
>  head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/dtraceUtil/tst.DestructWithFunction.d.ksh
> >
>  head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/dtraceUtil/tst.ZeroFunctionProbes.d.ksh
> >
>  head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/speculation/tst.NoSpecBuffer.exe
> >
> > Modified:
> head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/dtraceUtil/tst.DestructWithFunction.d.ksh
> >
> ==============================================================================
> > ---
> head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/dtraceUtil/tst.DestructWithFunction.d.ksh
> Sat Aug 31 13:24:22 2019        (r351642)
> > +++
> head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/dtraceUtil/tst.DestructWithFunction.d.ksh
> Sat Aug 31 14:41:58 2019        (r351643)
> > @@ -43,7 +43,7 @@ reader()
> >         while true
> >         do
> >                 sleep 0.1
> > -               cat /etc/motd > /dev/null
> > +               cat /COPYRIGHT > /dev/null
> >         done
> >  }
> >
> >
> > Modified:
> head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/dtraceUtil/tst.ZeroFunctionProbes.d.ksh
> >
> ==============================================================================
> > ---
> head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/dtraceUtil/tst.ZeroFunctionProbes.d.ksh
>   Sat Aug 31 13:24:22 2019        (r351642)
> > +++
> head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/dtraceUtil/tst.ZeroFunctionProbes.d.ksh
>   Sat Aug 31 14:41:58 2019        (r351643)
> > @@ -44,7 +44,7 @@ reader()
> >         while true
> >         do
> >                 sleep 0.1
> > -               cat /etc/motd > /dev/null
> > +               cat /COPYRIGHT > /dev/null
> >         done
> >  }
> >
> >
> > Modified:
> head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/speculation/tst.NoSpecBuffer.exe
> >
> ==============================================================================
> > ---
> head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/speculation/tst.NoSpecBuffer.exe
>  Sat Aug 31 13:24:22 2019        (r351642)
> > +++
> head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/speculation/tst.NoSpecBuffer.exe
>  Sat Aug 31 14:41:58 2019        (r351643)
> > @@ -26,5 +26,5 @@
> >  while true
> >  do
> >         sleep 0.1
> > -       cat /etc/motd > /dev/null
> > +       cat /COPYRIGHT > /dev/null
> >  done
> >
>
>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfrbwO%2BW7zVH6%2B=Jr09jONyqMnoT7ejavCh%2BNopBvcuyHg>