Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 5 Jan 1999 16:07:57 -0500 (EST)
From:      Bill Fumerola <billf@jade.chc-chimes.com>
To:        John Birrell <jb@cimlogic.com.au>
Cc:        cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, ports@FreeBSD.ORG
Subject:   Re: cvs commit: ports/graphics/giftrans Makefile ports/graphics/mpeg2codec/patches         patch-aa ports/graphics/splitmpg/patc
Message-ID:  <Pine.BSF.3.96.990105160515.29309D-100000@jade.chc-chimes.com>
In-Reply-To: <199901052102.IAA16286@cimlogic.com.au>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 6 Jan 1999, John Birrell wrote:

> > This will prevent any future platform nits as well as keep people who roll
> > there own packages and such happy.
> 
> And use -O, not -O2, for both (particularly for alpha).

I'm losing people here, or something. If it respects the systems CFLAGS,
it shouldn't be changed using a patch at all...

post-patch:

	${MV} ${WRKSRC}/Makefile ${WRKSRC}/Makefile.old
	${SED} -e 's#CFLAGS= -foo -m486 -bar#CFLAGS= ${CFLAGS}' \
	${WRKSRC}/Makefile.old > ${WRKSRC}/Makefile

90% of the CFLAGS bogons the live in our ports tree could be solved with
those 5 easy lines of Makefile-ness. patch(1) is not the answer.

- bill fumerola - billf@chc-chimes.com - BF1560 - computer horizons corp -
- ph:(800) 252-2421 - bfumerol@computerhorizons.com - billf@FreeBSD.org  -




To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.3.96.990105160515.29309D-100000>