From owner-svn-src-all@freebsd.org Fri Feb 9 20:22:10 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 845C1F21237 for ; Fri, 9 Feb 2018 20:22:10 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x22b.google.com (mail-io0-x22b.google.com [IPv6:2607:f8b0:4001:c06::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E9F1677458 for ; Fri, 9 Feb 2018 20:22:09 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x22b.google.com with SMTP id 72so10981265iom.10 for ; Fri, 09 Feb 2018 12:22:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=y0hJxBEVXWk/CiZbvLQ4DIzlaEm6F6NeX7acrDG9C1c=; b=hZvUzvg698f1DrU5Z6QwTZCe9vv8voiR97/oU8rRnWVQMY84soy3GKTqmrjkO97xUE Ef1jGI8ROzh96LxEBG+qHZ4Qnckm6dul5p8PXvoBadMtm++qhphGPGjMEF5qJeJWU9Bx b7G6/RjWE5RndL7rECRKuO5rje9I0+7+r65U3E/ODeziYhOodG/808n4YvXYhP+v1DB+ Vhk14uSfl/jFN6b0zAUdnhJ4XR8/FnSjOpvySiQBe0kbFgGUGVjj6fSDhzJSa+bI2i78 nRggdNLyfBKl7k98JJI14ehmF54JoebXEr63EJRl9NnuPTK/ZyIqXPNRZeaI2YuhtZRo Qb0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=y0hJxBEVXWk/CiZbvLQ4DIzlaEm6F6NeX7acrDG9C1c=; b=bJDDAXq+5AvFHN9VixtsSKVu+6FaR65J27PDL1eSndZ+G7TEIht9wJMo7a/ykAcG7W 319BhOwY0knJqlT/JiBam6Zyrgp4yz7QrVfWCuT5t0YFpVXPeRoKsQk5TI+9aABSmYMb xKkCq753G4hOtALmi9w/r4XIl5k/ueNAy06Efoj5YbPCL4vT+4mC/TOTRcPZEpU67HRY SQE3YRF3WPn+kBDno4ltbyu0PCjbUFSsuwHLVc9JyGba3yF040DlvCMjbeDp/EQPlPy8 wdMTqIrQ9wkGC8ThAniNP757/JGjiPO/wTTmhvfs1ZONlV95G26E9ww/SyPPtanBxIMO hjEQ== X-Gm-Message-State: APf1xPDCI5kG4XTn8k3rvESvlqr3hLJcW04/PCItKqCQXugiGRaZcQp8 VjB4Ef3phi/UYoUS9QOCSikmWN+gpopimiXcIuQLeg== X-Google-Smtp-Source: AH8x227sCgxSU01heFZ/th7sIxF4vadysrNX3iMWRqTcMK35IMS5jT9JSGXL3t+cwRaEDJXDtZeXn4vO53TEcGnDFWk= X-Received: by 10.107.167.69 with SMTP id q66mr4346675ioe.130.1518207729305; Fri, 09 Feb 2018 12:22:09 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.201.67 with HTTP; Fri, 9 Feb 2018 12:22:08 -0800 (PST) X-Originating-IP: [50.253.99.174] In-Reply-To: <20180209190450.GA85711@FreeBSD.org> References: <201802091550.w19FoXEb018181@repo.freebsd.org> <14002093.zLdzgIqnsv@ralph.baldwin.cx> <20180209190450.GA85711@FreeBSD.org> From: Warner Losh Date: Fri, 9 Feb 2018 13:22:08 -0700 X-Google-Sender-Auth: mKPOLH1qF1GBY9ZikDCnWCYcTHw Message-ID: Subject: Re: svn commit: r329064 - head/share/zoneinfo To: Alexey Dokuchaev Cc: John Baldwin , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers , Warner Losh Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Feb 2018 20:22:10 -0000 On Fri, Feb 9, 2018 at 12:04 PM, Alexey Dokuchaev wrote: > On Fri, Feb 09, 2018 at 11:50:35AM -0700, Warner Losh wrote: > > On Fri, Feb 9, 2018 at 10:49 AM, John Baldwin wrote: > > > On Friday, February 09, 2018 03:50:33 PM Warner Losh wrote: > > > > New Revision: 329064 > > > > URL: https://svnweb.freebsd.org/changeset/base/329064 > > > > > > > > Log: > > > > We don't actually need env here, so drop it. All shells allow > setting > > > > of shell variables for the next command like this. > > > > > > Eh: > > > > > > % LC_ALL=C env > > > LC_ALL=C: Command not found. > > > > > > csh and tcsh don't let you set environment variables as a prefix. > > > > > > That said, if you try to use csh as the SHELL for make I bet many > things > > > would break. > > > > Right, all shells supported as SHELL for make. csh isn't on the list of > > supported shells. Your bet is right: a lot of things do break. > > I don't really understand why we're discussing it: (t)csh, fish, whatever > are for interactive use *only*. Scripts (and makefiles) should only be > written for standard plain POSIX shell. > Right. 'all shells' in my original simply meant that this has been a feature of /bin/sh for long enough that we won't have anything to worry about if we build on a foreign OS using something weird like bash. Warner