From nobody Sat Jul 26 22:51:54 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bqKk23XJ9z62qJ1; Sat, 26 Jul 2025 22:51:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bqKk229kVz47NX; Sat, 26 Jul 2025 22:51:54 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1753570314; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xsMZoWF61bzRonGBKE8XqC+Os6ztZHh1I5GjExWsvwc=; b=Vlb4KNN6foZ/zo5DQ9i5TJAHjZ1lmkx+ZqKjVIYOjp49BuK+jzz4gqO69xAILoJEz4u58u /0nRa/lRk+3QALA/10q59V2fUpf6uSmG0uexEHER+v0ftAUvqOb7Ob36P9IEOCFynjgQYt Qy6jQBt5Dqn72Z6Yvp4MJj4Sg4jOIDDL5Qbg1sAVL9hSVnudQV3EKcx5OWo9Z/jX3xdTKT Lj/XEu+mHKnpQdSOasZC3IR58+Rh1qBJANvM+nEQ00MjVf75DL8DOsEHktYQK8SP/7YYUF Qd41VPiYItevrwwcBzsPPbXuC37bMbS+o56Rlf4EpHsbTOsTqFoRMT2uI03Ilw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1753570314; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xsMZoWF61bzRonGBKE8XqC+Os6ztZHh1I5GjExWsvwc=; b=v9oLLq1R2c5u2RTk3iNsGHumn0eQRj6WZPGQD0+OfGiXZcTp1A97AI8b7YdBhDShEzm+xs RpbH/SpSxm23EkBkmKg1WZGTIlulRfSJ122ZTVBDPb3KyNc0Z3Due28XL7WfvwKkWKXXvT tuV78xKgWvQ1sp3N3IQhJapWtv2/TVBX64vxt/bYbHVZO9bt+nhekb2MJOvC0H5nhLAHxC gWS6QIsCyALGJOf0JW+plM2A80e+yv6dl8YN0lMXde3Nk/PRkNrLCEu4jlf+LTCytfhfAJ CdR0obQvXtxxQYV+g7NFuvk+Iwr2DrAI0k+4w3oIbgvVG1Mo2V4AQ4/HIx1Nlg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1753570314; a=rsa-sha256; cv=none; b=vQJQBZkE3A4x+qtPNu+Qnr+eIQl/0EYNyFRB4IPqXbKPb38JkJprecaZ54ikHIL7PuhrbE w01Nac13ziI0nohC+kaBKwqMh0xCyA3rCtEBbbu1BPWGUKGVs8sJY6UPKEXJV0SpzJ5G9n ge/Mgk+Uc1KXPCpfqFkF8Y88sheyhlodMG8vS0Fnb7Ehe9DfndFn3U547WL3wSpd1VcuXd PmwB+np2N5Sjk4T87nAQJRl07+bBEIYuTrWe0Ne7QQPKnkosjS8Y4H/NWHmH4kR30Ie+IZ AfTnWSsHB/VHn9O82VnS22IRkSyYim6JCLJPCWvx4nkAIjUkSVC+4762utHuNg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bqKk21lcRzq50; Sat, 26 Jul 2025 22:51:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 56QMpsYo019794; Sat, 26 Jul 2025 22:51:54 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 56QMpsY5019791; Sat, 26 Jul 2025 22:51:54 GMT (envelope-from git) Date: Sat, 26 Jul 2025 22:51:54 GMT Message-Id: <202507262251.56QMpsY5019791@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ed Maste Subject: git: 7507d6ca0e75 - main - vmm: Clean up legacy create/destroy interface List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 7507d6ca0e754b2bb9354b54b3a20f73cfe1f06a Auto-Submitted: auto-generated The branch main has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=7507d6ca0e754b2bb9354b54b3a20f73cfe1f06a commit 7507d6ca0e754b2bb9354b54b3a20f73cfe1f06a Author: Ed Maste AuthorDate: 2025-07-26 22:51:06 +0000 Commit: Ed Maste CommitDate: 2025-07-26 22:51:37 +0000 vmm: Clean up legacy create/destroy interface Add sysctl descriptions, and remove surprising default text. PR: 288437 Reviewed by: jhb, markj Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D51533 --- sys/dev/vmm/vmm_dev.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sys/dev/vmm/vmm_dev.c b/sys/dev/vmm/vmm_dev.c index 819debadd1ac..2e2ae0a162d8 100644 --- a/sys/dev/vmm/vmm_dev.c +++ b/sys/dev/vmm/vmm_dev.c @@ -820,7 +820,6 @@ sysctl_vmm_destroy(SYSCTL_HANDLER_ARGS) buflen = VM_MAX_NAMELEN + 1; buf = malloc(buflen, M_VMMDEV, M_WAITOK | M_ZERO); - strlcpy(buf, "beavis", buflen); error = sysctl_handle_string(oidp, buf, buflen, req); if (error == 0 && req->newptr != NULL) error = vmmdev_lookup_and_destroy(buf, req->td->td_ucred); @@ -830,7 +829,7 @@ sysctl_vmm_destroy(SYSCTL_HANDLER_ARGS) SYSCTL_PROC(_hw_vmm, OID_AUTO, destroy, CTLTYPE_STRING | CTLFLAG_RW | CTLFLAG_PRISON | CTLFLAG_MPSAFE, NULL, 0, sysctl_vmm_destroy, "A", - NULL); + "Destroy a vmm(4) instance (legacy interface)"); static struct cdevsw vmmdevsw = { .d_name = "vmmdev", @@ -909,7 +908,6 @@ sysctl_vmm_create(SYSCTL_HANDLER_ARGS) buflen = VM_MAX_NAMELEN + 1; buf = malloc(buflen, M_VMMDEV, M_WAITOK | M_ZERO); - strlcpy(buf, "beavis", buflen); error = sysctl_handle_string(oidp, buf, buflen, req); if (error == 0 && req->newptr != NULL) error = vmmdev_create(buf, req->td->td_ucred); @@ -919,7 +917,7 @@ sysctl_vmm_create(SYSCTL_HANDLER_ARGS) SYSCTL_PROC(_hw_vmm, OID_AUTO, create, CTLTYPE_STRING | CTLFLAG_RW | CTLFLAG_PRISON | CTLFLAG_MPSAFE, NULL, 0, sysctl_vmm_create, "A", - NULL); + "Create a vmm(4) instance (legacy interface)"); static int vmmctl_open(struct cdev *cdev, int flags, int fmt, struct thread *td)