From owner-svn-src-all@freebsd.org Fri Nov 24 17:32:14 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 49264DECB8D; Fri, 24 Nov 2017 17:32:14 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [88.99.82.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0E0737CF89; Fri, 24 Nov 2017 17:32:13 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2016.home.selasky.org (unknown [62.141.128.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 7D44D26014D; Fri, 24 Nov 2017 18:32:09 +0100 (CET) Subject: Re: svn commit: r326169 - in head: . contrib/ofed lib/libc/locale share/mk sys/amd64/amd64 sys/amd64/conf sys/conf sys/contrib/rdma/krping sys/dev/cxgbe sys/dev/cxgbe/common sys/dev/cxgbe/iw_cxgbe sys/... To: Mark Johnston Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201711241450.vAOEoSFW056744@repo.freebsd.org> <20171124150044.GA94025@raichu> <20171124172239.GA1098@raichu> From: Hans Petter Selasky Message-ID: <5404fdf3-59f0-7bb0-772e-a9003671b0ef@selasky.org> Date: Fri, 24 Nov 2017 18:29:25 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171124172239.GA1098@raichu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Nov 2017 17:32:14 -0000 On 11/24/17 18:22, Mark Johnston wrote: > On Fri, Nov 24, 2017 at 06:09:25PM +0100, Hans Petter Selasky wrote: >> On 11/24/17 16:00, Mark Johnston wrote: >>> Are there non-trivial interoperability issues between mthca and the >>> updated OFED stack? If so, could you describe them? If not, I would >>> strongly prefer to retain the mthca driver, as Isilon still has plenty >>> of hardware making use of it. >> >> Hi, >> >> There are no technical reasons except Mellanox hasn't focused on the >> mthca driver in this upgrade. With little effort you should be able to >> pull libmthca and the mthca driver from the mentioned sources and make >> it work. > > In that case, could we please bring it back in to svn? It seems silly to > remove a driver just because it's not being actively maintained: that > isn't the bar for keeping drivers in FreeBSD, and I note that mthca is > still present in Linux. If there is some work needed to get the kernel > and userland components to compile again, I'm happy to do it; I just > don't want to have to maintain an out-of-tree HCA driver when there's no > good reason it can't stay in svn. > Sure, but we probably want to put it into sys/dev/mthca instead of sys/ofed/xxx . Are you saying you want to pull it in yourself and make it compile? --HPS