From owner-svn-src-all@freebsd.org Wed Dec 20 20:28:09 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3294EEA2714 for ; Wed, 20 Dec 2017 20:28:09 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from sonic301-18.consmr.mail.bf2.yahoo.com (sonic301-18.consmr.mail.bf2.yahoo.com [74.6.129.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EC3F280BE8 for ; Wed, 20 Dec 2017 20:28:08 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1513801682; bh=67x1t0EptFEUq5SYQDLCZ3Fa3V+l1mEF2Jf3/pDGdwI=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From:Subject; b=Za4GMNGVxpijajh2RgxJG/fBIsXTw+Xp+gcGi8sIdX1XZz2QmRYjlOo19NGsvkuo+fFN9WbyjQSuBcJstXnSrsFOE4SoNj9g9ulnQND79WeZHlsRXUsA2xv7q8CbEovP1WObs8V2Jz2ys7heBtXD3gPizK+7vrstcYkuA+bJfxxXmPAuhvbhyg1hSuWKEqye3ZAPo5lZrkI3oGE/1v9HqH1XZ/a6mYgPtXSqrunWQqekblVowgpfvC5lU0x3JT4zkLDlEnboL3E26gkJduqvf06MTzsQKtiRpxOipLnS2zT69ScFHbrG/gONI85twr/4KIZIyTEwthzuhlURhylDwg== X-YMail-OSG: wQ5BAmYVM1lJUOqSexZuqgYWg3oRO_DQsc1OjBV0RGbyBLWUOMtPvPl_9aM_bbM LnK0Rj.7IrvNUw7qQDuBgrm4tFeNQ2dOHi93TedpbD4urxb_dZixeYAPVmTVSA3cTEqtZ_wyvXTY hwkRNTR2yb.sR00srIEWjPqMkr.jEua78oLqmBc3U.sMipY5mgMfUqvy8sC2fYFoekXpPCzv6Bhi _PJqaYoDhynJs3MO6o.F0S9ScEyze7TMR7qd3rktsAm3q5Om_ZYKwrZm6E4.jC0stAEuBBoy4oUZ CAMjkExf6wiUOiRbcO5Ts8TodnWpBOFqN1.tLzjYKHlwfzIEMEjc1dZ0QwIfsRwNRyJhKZLB8yPK EkCAjwddvQsdo.RyWvPRLiSw.NH7tyJdN7S6da9Fia2MRC1__YSZ1rg_d.h8smFzo3YM8fRX54Zx s6GChjUiwL_JAiAq47qTH1kLrpbCROmCCeAcceQ3rtGYT4nfVCCvL56pfbfWqPwfBW8fgn2s6 Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.bf2.yahoo.com with HTTP; Wed, 20 Dec 2017 20:28:02 +0000 Received: from smtp105.rhel.mail.bf1.yahoo.com (EHLO [192.168.0.6]) ([98.139.231.38]) by smtp408.mail.bf1.yahoo.com (JAMES SMTP Server ) with ESMTPA ID f23557ce4ac3b2b7db54cc25ca128d0e; Wed, 20 Dec 2017 20:28:01 +0000 (UTC) Subject: Re: svn commit: r327005 - in head: sbin/ipfw sys/sys usr.sbin/watch To: rgrimes@freebsd.org Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201712200255.vBK2tWT0023724@pdx.rh.CN85.dnsmgr.net> From: Pedro Giffuni Message-ID: <34c37415-002a-f5fa-7a06-e98bcfc9c133@FreeBSD.org> Date: Wed, 20 Dec 2017 15:28:01 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <201712200255.vBK2tWT0023724@pdx.rh.CN85.dnsmgr.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Dec 2017 20:28:09 -0000 On 12/19/17 21:55, Rodney W. Grimes wrote: >> >>> On Dec 19, 2017, at 19:15, Rodney W. Grimes wrote: >>> >>>> Author: pfg >>>> Date: Tue Dec 19 22:40:16 2017 >>>> New Revision: 327005 >>>> URL: https://svnweb.freebsd.org/changeset/base/327005 >>>> >>>> Log: >>>> SPDX: These are fundamentally BSD-2-Clause. >>>> >>>> They just omit the introductory line and numbering. >>> I again must assert that it would be better to not apply an SPDX than to >>> apply one that is not an exact match for the license. >>> >>> >> Not being a lawyer, I would normally agree, however: > This isnt about any legal issue. > >> 1) SPDX IDs are only advisory: we always keep the exact license text, which is what has legal value. > And we should do our best to provide the most accurate advisory we can, > and we know that this is not a direct copy of the BSD 2 clause, so making > advice that it is, IMHO, would be poor advice. > >> 2) The license is detected by license scanners as BSD and it has two clauses so the description fits. > And a human reading it sees it reads like a 2 clause but does not match a 2 clause exactly so > how do I trust any of this SPDX stuff as being done with some ration of sanity. > >> FWIW, according to SPDX lawyers, the numbering is not relevant and it would appear to me that the phrase: >> "Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:? doesn?t add any information to the two clauses, which read: > Again, not a legal issue, an issue of this is not an exact BSD-2-Clause so I > do not believe that we should tag it as such. Basically if we are doing this > "close enough" thing it means the SPDX tags are actually pretty useless for > anyone trying to do a legal evaluation cause they are just going have to > completly redo what was done in adding the SPDX tags, and if that is the > case we should seriously consider just what value do these have in the > tree? > > Indeed .. after having the change reviewed by someone objective, I have reverted the change in r327040. Thanks for speaking up! Pedro.