From nobody Sun Aug 24 03:37:34 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4c8fkn4snqz64yTV; Sun, 24 Aug 2025 03:37:37 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta004.cacentral1.a.cloudfilter.net (omta002.cacentral1.a.cloudfilter.net [3.97.99.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4c8fkn1YDCz3X2H; Sun, 24 Aug 2025 03:37:37 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4004a.ext.cloudfilter.net ([10.228.9.227]) by cmsmtp with ESMTPS id pynLuNXgM5Mqyq1Y0uFtUw; Sun, 24 Aug 2025 03:37:36 +0000 Received: from spqr.komquats.com ([70.66.136.217]) by cmsmtp with ESMTPSA id q1XyuCaCrJhBPq1XzucZlD; Sun, 24 Aug 2025 03:37:36 +0000 X-Auth-User: cschuber X-Authority-Analysis: v=2.4 cv=QY3Fvdbv c=1 sm=1 tr=0 ts=68aa8900 a=h7br+8Ma+Xn9xscxy5znUg==:117 a=h7br+8Ma+Xn9xscxy5znUg==:17 a=kj9zAlcOel0A:10 a=2OwXVqhp2XgA:10 a=6I5d2MoRAAAA:8 a=EkcXrb_YAAAA:8 a=T_YFPyFoAAAA:8 a=CjxXgO3LAAAA:8 a=YxBL1-UpAAAA:8 a=LQb5wrXf6FiGhbvXbx0A:9 a=CjuIK1q_8ugA:10 a=LK5xJRSDVpKd5WXXoEvA:22 a=fKaBkT6cBtmegwcwHIDe:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy.cwsent.com [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id 6804088D; Sat, 23 Aug 2025 20:37:34 -0700 (PDT) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (Postfix) with ESMTP id 53E1943D; Sat, 23 Aug 2025 20:37:34 -0700 (PDT) Date: Sat, 23 Aug 2025 20:37:34 -0700 From: Cy Schubert To: ShengYi Hung Cc: Gordon Bergling , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 1685192ea1fa - main - hkbd: remove erorr detection in KDSKBSTATE ioctl Message-ID: <20250823203726.55c5a5ec@slippy.cwsent.com> In-Reply-To: References: <202508230450.57N4oxwG023161@gitrepo.freebsd.org> <20250823171011.BCFFF189@slippy.cwsent.com> Organization: KOMQUATS X-Mailer: Claws Mail 3.21.0 (GTK+ 2.24.33; amd64-portbld-freebsd15.0) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4xfPrBzmEbe6lEzDyZ6Q0T9cv4UkqZKDtKJTKjGY3otgBLkjnCzHzL/fZKJxwI2wDlhklzT46UPJJeHicKnxlDPmAXh6tgwoklZvKbejw4Z3Mb9omYkyj4 G0InxMoNgr1Av7kWmVxnFoCPW7jYEXpU+aGV4eZYlfc3JJt2oW/E8E5btYplyYMPM+JKm71jZFAEYSjqoxf0wuN/QMsp+fb1q9PY2+YEH9dKUgf72NNLOT4g D3BMCUdez00O2v5gwdxahAKPwjQR5aBnRqAummNjeJ0Z+iEHFlxYl57NXD64qenqIzpR0yIdeEEeHXOr9gApkEHBTGs9Vpk+2U5BrgF73esj1axpENRGd7jy 3le8/cCe X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4c8fkn1YDCz3X2H On Sat, 23 Aug 2025 13:27:23 -0400 ShengYi Hung wrote: > Hello: > > I only submit two patches. What is the third patch you have mentioned? > Is the one setting "sysctl usbhid=1"? > > On 8/23/25 13:10, Cy Schubert wrote: > > In message , ShengYi Hung writes: > >> Hello, thanks for the reminder. I compile the standalone module to test so > >> didn't discover that. Fix it right now. > >> Gordon Bergling writes: > >> > >> > >>> Hi ShengYi, > >>> > >>> On Sat, Aug 23, 2025 at 04:50:59AM +0000, ShengYi Hung wrote: > >>>> The branch main has been updated by aokblast: > >>>> > >>>> URL: https://cgit.FreeBSD.org/src/commit/?id=1685192ea1faac28f2d4feede53e7 > >> 0b6a380500f > >>>> commit 1685192ea1faac28f2d4feede53e70b6a380500f > >>>> Author: ShengYi Hung > >>>> AuthorDate: 2025-08-21 17:59:15 +0000 > >>>> Commit: ShengYi Hung > >>>> CommitDate: 2025-08-23 04:50:09 +0000 > >>>> > >>>> hkbd: remove erorr detection in KDSKBSTATE ioctl > >>>> > >>>> The KDSKBSTATE ioctl brings the LED up. However, some keyboards (like > >> qemu > >>>> keyboard) may not have LED or failed to set the LED due to unexpected > >> reason. > >>>> Therefore, removing the error check as ukbd(4) does allow the keyboard > >> works > >>>> correctly with kbdcontrol(4). > >>>> > >>>> Also move hw.hid.hkbd.no_leds sysctl out of HID_BUG thus users can > >>>> disable setting LEDs > >>>> > >>>> PR: 288968 > >>>> Reviewed by: wulf > >>>> Tested by: trashcan@ellael.org, marklmi26-fbsd@yahoo.com, trkelle > >> rs@gmail.coom > >>>> Approved by: lwsu (mentor), markj (mentor) > >>>> MFC after 1 week > >>>> Sponsored by: The FreeBSD Foundation > >>>> Differential Revision: https://reviews.freebsd.org/D52101 > >>>> > >>>> mvalsmva > >>>> --- > >>> I am not sure how this is related, but since that commit, buildkernel of GE > >> NERIC is broken both > >>> on amd64 and aarch64. The following error is from an amd64 build, aarch64 i > >> s the same. > >>> ----------------------------- > >>> /storage/freebsd/src/current/sys/dev/hid/hkbd.c:1831:10: error: called ob > >> ject type 'char[5]' is not a function or function pointer > >>> 1831 | DPRINTF(("error %d", error)); > >>> | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~ > >>> /storage/freebsd/src/current/sys/dev/hid/hid.h:212:34: note: expanded fro > >> m macro 'DPRINTF' > >>> 212 | #define DPRINTF(...) DPRINTFN(1, __VA_ARGS__) > >>> | ~~~~~~~~~~~~^~~~~~~~~~~~ > >>> /storage/freebsd/src/current/sys/dev/hid/hid.h:208:17: note: expanded fro > >> m macro 'DPRINTFN' > >>> 208 | printf("%s: " fmt, \ > >>> | ~~~~~~ ^ > >>> 1 error generated. > >>> --- hkbd.o --- > >>> *** [hkbd.o] Error code 1 > >>> ----------------------------- > >>> > >>> --Gordon > >> -- > >> Best Regards. > >> ShengYi Hung. > >> > > My machines running X (laptops), > > > > - the right mouse key no longer works under X, I can no longer use X, > > - the caps-lock light will not display under X > > - on the text console works, X does not. > > > > The three commits related have bee reverted locally, functionality has > > returned. > > > > > Best Regards. > > ShengYi Hung. > The hashes are, 1685192ea1fa 8a847947153e 6ea7e1f92882 I don't think 8a847947153e is related. 6ea7e1f92882 must be reverted in order to revert 1685192ea1fa. -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e**(i*pi)+1=0