From owner-freebsd-current@FreeBSD.ORG Mon Nov 7 19:37:28 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C7D27106566C; Mon, 7 Nov 2011 19:37:28 +0000 (UTC) (envelope-from lacombar@gmail.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id C7A988FC0C; Mon, 7 Nov 2011 19:37:27 +0000 (UTC) Received: by wwp14 with SMTP id 14so7197365wwp.31 for ; Mon, 07 Nov 2011 11:37:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=GNwCkcRBQdx76CKtQAD9fPNuKW/+RVij8tHt5Na+wQo=; b=Yh2gmEqkw+9xAzdjB3iOK+dOVHvZuM+e34u8uVuegd9Xhe/zvmNHUNa0HAaOv06z35 zg2JAS9EiiRb24uIEmqJvNR6tHb3bynmQXyXyNjQm22j8ukUXKYPfqou2628zc6yBumk LsuzIJ7jFfkCMm10wzc2oc2yPJXZzxwttW98s= MIME-Version: 1.0 Received: by 10.181.13.165 with SMTP id ez5mr9320294wid.51.1320694646792; Mon, 07 Nov 2011 11:37:26 -0800 (PST) Received: by 10.180.81.200 with HTTP; Mon, 7 Nov 2011 11:37:26 -0800 (PST) In-Reply-To: References: <4EB11C32.80106@FreeBSD.org> <4EB22938.4050803@rice.edu> <20111103132437.GV50300@deviant.kiev.zoral.com.ua> <4EB2D48E.1030102@rice.edu> <20111104100828.GG50300@deviant.kiev.zoral.com.ua> <4EB40015.5040100@rice.edu> <20111104153004.GK50300@deviant.kiev.zoral.com.ua> <4EB4095D.3030303@rice.edu> <20111104160339.GM50300@deviant.kiev.zoral.com.ua> <20111105141306.GW50300@deviant.kiev.zoral.com.ua> Date: Mon, 7 Nov 2011 14:37:26 -0500 Message-ID: From: Arnaud Lacombe To: Attilio Rao Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: "K. Macy" , Alan Cox , Andriy Gapon , freebsd-current@freebsd.org, Benjamin Kaduk , Kostik Belousov , Penta Upa Subject: Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Nov 2011 19:37:28 -0000 Hi, On Mon, Nov 7, 2011 at 2:03 PM, Arnaud Lacombe wrote: > On Mon, Nov 7, 2011 at 4:36 AM, Attilio Rao wrote: >> I'm unsure if this replies to your concerns because you just criticize >> without making a real technical question in this post. >> > I made comments on 3 points: > =A0- using internal implementation details of mutex(9) is broken > =A0- LOCK_FILE/LOCK_LINE are broken (a bit of a divergence on the > original subject :/) > =A0- there is _no_ reason not to use inlines function for such trivial on= eliners > ok, I read the original thread, now that I understand the purpose of the patch. It would make the third comment irrelevant, but I still do not agree about the reason of the patch. - ARnaud