From owner-svn-src-head@freebsd.org Fri Oct 18 12:48:31 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 20FCC14FFF4; Fri, 18 Oct 2019 12:48:31 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: from mail-qt1-f195.google.com (mail-qt1-f195.google.com [209.85.160.195]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46vm6k0rwLz4XCc; Fri, 18 Oct 2019 12:48:29 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: by mail-qt1-f195.google.com with SMTP id n17so8876991qtr.4; Fri, 18 Oct 2019 05:48:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ptwrXBQ/S7XqHblVwTVS2rrB6Q4RfrB/tZugCHCGG5Q=; b=AzOxip0lISl+H1MuthCrvITWk2wcbYlebzXfxYlIqS1C+zWNzbfquBcBpod8wWLxU2 ZIAwX8rV1wByvKN+NbjMbI2iDiIxXXb6qAENenPBNb3nAfLvKgC7a1Zn54CYSf8NxSiX v9DcWyqHzHsczjEtNtRtF/pAh53e+snQAtOzteOINQjiA8WMvYMkqb3S9gRcpDxgIEMI zCYStY7Nj9flhwci5Wz7nup4v3aHrRhh3tqQBjMXiy5I4ed2aE2E8OXdPxfxnCNuTeUo MbZBOum1PRxZDUd8YS3xKG7RnLUZXuT7L5SI1i/7zzFSf3vEHgROWInwr75Yz3ZdguuX tWRQ== X-Gm-Message-State: APjAAAXrNHd4uXquOTUVWjgHuNYcQuDsXCsrTs/2hDe3USUH44yWYLMF f2ZYNMAj7X6HlscWfsg9ntZGvBn2 X-Google-Smtp-Source: APXvYqxmwPzz2VkolHq/RB5n8FYe3YTcf+1ZoQ0cIVXkZc4/ZJW4rtBt/q2b4mfsH6HxlqSPwgYtjA== X-Received: by 2002:ac8:7595:: with SMTP id s21mr9384413qtq.373.1571402908786; Fri, 18 Oct 2019 05:48:28 -0700 (PDT) Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com. [209.85.160.173]) by smtp.gmail.com with ESMTPSA id e42sm4742981qte.26.2019.10.18.05.48.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Oct 2019 05:48:28 -0700 (PDT) Received: by mail-qt1-f173.google.com with SMTP id u40so8830567qth.11; Fri, 18 Oct 2019 05:48:28 -0700 (PDT) X-Received: by 2002:ad4:524b:: with SMTP id s11mr9291670qvq.112.1571402908278; Fri, 18 Oct 2019 05:48:28 -0700 (PDT) MIME-Version: 1.0 References: <201910172133.x9HLX1kl071044@repo.freebsd.org> <20191018122104.389ffb7a@hermann.fritz.box> <20191018140045.31d269b0@ernst.home> In-Reply-To: <20191018140045.31d269b0@ernst.home> From: Kyle Evans Date: Fri, 18 Oct 2019 07:48:16 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r353700 - in head: share/man/man4 sys/amd64/conf sys/conf sys/gdb sys/i386/conf sys/kern sys/net sys/sys To: gljennjohn@gmail.com Cc: "Hartmann, O." , Conrad Meyer , svn-src-head , svn-src-all , src-committers Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 46vm6k0rwLz4XCc X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of byondlenox@gmail.com designates 209.85.160.195 as permitted sender) smtp.mailfrom=byondlenox@gmail.com X-Spamd-Result: default: False [-3.93 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[kyle-evans.net]; RWL_MAILSPIKE_GOOD(0.00)[195.160.85.209.rep.mailspike.net : 127.0.0.18]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[195.160.85.209.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; IP_SCORE(-1.93)[ip: (-4.24), ipnet: 209.85.128.0/17(-3.24), asn: 15169(-2.09), country: US(-0.05)]; FORGED_SENDER(0.30)[self@kyle-evans.net,byondlenox@gmail.com]; FREEMAIL_TO(0.00)[gmail.com]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[self@kyle-evans.net,byondlenox@gmail.com]; TAGGED_FROM(0.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Oct 2019 12:48:31 -0000 On Fri, Oct 18, 2019 at 7:00 AM Gary Jennejohn wrote: > > On Fri, 18 Oct 2019 12:21:04 +0200 > "Hartmann, O." wrote: > > > On Thu, 17 Oct 2019 21:33:01 +0000 (UTC) > > Conrad Meyer wrote: > > > > > Author: cem > > > Date: Thu Oct 17 21:33:01 2019 > > > New Revision: 353700 > > > URL: https://svnweb.freebsd.org/changeset/base/353700 > > > > > > Log: > > > Implement NetGDB(4) > > > > > > NetGDB(4) is a component of a system using a panic-time network > > > stack to remotely debug crashed FreeBSD kernels over the network, > > > instead of traditional serial interfaces. > > > > > > There are three pieces in the complete NetGDB system. > > > > > > First, a dedicated proxy server must be running to accept > > > connections from both NetGDB and gdb(1), and pass bidirectional > > > traffic between the two protocols. > > > > > > Second, the NetGDB client is activated much like ordinary 'gdb' and > > > similarly to 'netdump' in ddb(4) after a panic. Like other > > > debugnet(4) clients (netdump(4)), the network interface on the route > > > to the proxy server must be online and support debugnet(4). > > > > > > Finally, the remote (k)gdb(1) uses 'target remote :' > > > (like any other TCP remote) to connect to the proxy server. > > > > > > The NetGDB v1 protocol speaks the literal GDB remote serial > > > protocol, and uses a 1:1 relationship between GDB packets and > > > sequences of debugnet packets (fragmented by MTU). There is no > > > encryption utilized to keep debugging sessions private, so this is > > > only appropriate for local segments or trusted networks. > > > > > > Submitted by: John Reimer (earlier > > > version) Discussed some with: emaste, markj > > > Relnotes: sure > > > Differential Revision: https://reviews.freebsd.org/D21568 > > > > > > Added: > > > head/share/man/man4/netgdb.4 (contents, props changed) > > > head/sys/gdb/netgdb.c (contents, props changed) > > > head/sys/gdb/netgdb.h (contents, props changed) > > > Modified: > > > head/share/man/man4/Makefile > > > head/share/man/man4/ddb.4 > > > head/sys/amd64/conf/GENERIC > > > head/sys/conf/NOTES > > > head/sys/conf/files > > > head/sys/conf/options > > > head/sys/gdb/gdb.h > > > head/sys/gdb/gdb_int.h > > > head/sys/gdb/gdb_main.c > > > head/sys/gdb/gdb_packet.c > > > head/sys/i386/conf/GENERIC > > > head/sys/kern/subr_kdb.c > > > head/sys/net/debugnet.c > > > head/sys/net/debugnet.h > > > head/sys/net/debugnet_inet.c > > > head/sys/net/debugnet_int.h > > > head/sys/sys/kdb.h > > > head/sys/sys/param.h > > > > > > Modified: head/share/man/man4/Makefile > > > ============================================================================== > > > --- head/share/man/man4/Makefile Thu Oct 17 21:25:50 > > > 2019 (r353699) +++ head/share/man/man4/Makefile Thu Oct > > > 17 21:33:01 2019 (r353700) @@ -307,6 +307,7 @@ MAN= > > > aac.4 \ net80211.4 \ > > > netdump.4 \ > > > netfpga10g_nf10bmac.4 \ > > > + netgdb.4 \ > > > netgraph.4 \ > > > netintro.4 \ > > > netmap.4 \ > > > > > [...] > > > > > > Having "nooptions NETGDB # netgdb(4) client support" > > defined in my kernel config file, buildkernel fails with the error > > shown below. > > > > [...] > > --- debugnet.o --- > > /usr/src/sys/net/debugnet.c:662:4: error: implicit declaration of > > function 'db_printf' is invalid in C99 > > [-Werror,-Wimplicit-function-declaration] db_printf("%s: Could not get > > route for that server.\n", ^ /usr/src/sys/net/debugnet.c:662:4: note: > > did you mean 'if_printf'? /usr/src/sys/net/if_var.h:679:5: note: > > 'if_printf' declared here int if_printf(struct ifnet *, const char > > *, ...) __printflike(2, 3); ^ > > 1 error generated. > > And I also had to add "nooptions NETDUMP" to get the kernel to compile > and link. > diff --git a/sys/conf/files b/sys/conf/files index e47fe27466c..4bc5770e08c 100644 --- a/sys/conf/files +++ b/sys/conf/files @@ -4298,7 +4298,7 @@ netinet/libalias/alias_mod.c optional libalias | netgraph_nat netinet/libalias/alias_proxy.c optional libalias inet | netgraph_nat inet netinet/libalias/alias_util.c optional libalias inet | netgraph_nat inet netinet/libalias/alias_sctp.c optional libalias inet | netgraph_nat inet -netinet/netdump/netdump_client.c optional inet netdump +netinet/netdump/netdump_client.c optional inet debugnet netdump netinet6/dest6.c optional inet6 netinet6/frag6.c optional inet6 netinet6/icmp6.c optional inet6 That should fix that one. Thanks, Kyle Evans