Date: Mon, 31 Aug 2020 14:57:58 -0400 From: Ed Maste <emaste@freebsd.org> To: "Rodney W. Grimes" <rgrimes@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r364321 - head/sbin/ipfw Message-ID: <CAPyFy2CP36c3b66h5sKmoz8zscdSAU-5pc8hq2=6NiV0ePuLiw@mail.gmail.com> In-Reply-To: <202008311409.07VE9Ch9033206@gndrsh.dnsmgr.net> References: <CAPyFy2C1F9J5o38RcZHm%2BtD7gXQKxugaPhOfyjOoKem2tKXY=Q@mail.gmail.com> <202008311409.07VE9Ch9033206@gndrsh.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 31 Aug 2020 at 10:09, Rodney W. Grimes
<freebsd@gndrsh.dnsmgr.net> wrote:
>
> > Hrm, it seems this reply ended up in my spam folder; sorry for not
> > replying until now.
>
> lol Oh, bad filter :-)
>
> > > > *strchr(timestr, '\n') = '\0';
> > > > bprintf(bp, "%s ", timestr);
> > > ^ Isnt this the +1 space?
> > >
> > > > } else {
> > > > - bprintf(bp, "%*s", twidth, " ");
> > > > + bprintf(bp, "%*s", twidth + 1, " ");
> > > ^missing from this string?
> >
> > Inserting an extra space in the format string would also work, sure. I
> > considered doing it that way but in the end decided it's not
> > materially more clear one way or another, so used the patch as
> > submitted.
>
> For me the + 1 leads to a "why is this here", where as the space
> in the format string clearly matches the other condition of the else.
> Also + 1 causes a run time computation, the extra space does not.
No, but the extra space adds a format string character which will be
more costly than the +1. I would have used "%*s " if twidth was
already used in the other case, to keep them consistent.
Anyhow, I think this isn't worth bikeshedding; I have no objection if
anyone feels "%*s " is more clear and wants to commit that change.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2CP36c3b66h5sKmoz8zscdSAU-5pc8hq2=6NiV0ePuLiw>