From owner-svn-src-all@FreeBSD.ORG  Fri Feb 27 21:31:38 2009
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A26B910656BA;
	Fri, 27 Feb 2009 21:31:38 +0000 (UTC) (envelope-from sam@freebsd.org)
Received: from ebb.errno.com (ebb.errno.com [69.12.149.25])
	by mx1.freebsd.org (Postfix) with ESMTP id 7590E8FC13;
	Fri, 27 Feb 2009 21:31:38 +0000 (UTC) (envelope-from sam@freebsd.org)
Received: from trouble.errno.com (trouble.errno.com [10.0.0.248])
	(authenticated bits=0)
	by ebb.errno.com (8.13.6/8.12.6) with ESMTP id n1RLVc73050903
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Fri, 27 Feb 2009 13:31:38 -0800 (PST) (envelope-from sam@freebsd.org)
Message-ID: <49A85BB9.4080304@freebsd.org>
Date: Fri, 27 Feb 2009 13:31:37 -0800
From: Sam Leffler <sam@freebsd.org>
Organization: FreeBSD Project
User-Agent: Thunderbird 2.0.0.18 (X11/20081209)
MIME-Version: 1.0
To: Andrew Thompson <thompsa@freebsd.org>
References: <200902272114.n1RLETGJ083343@svn.freebsd.org>
In-Reply-To: <200902272114.n1RLETGJ083343@svn.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-DCC-Misty-Metrics: ebb.errno.com; whitelist
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r189123 - head/sys/dev/usb/wlan
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Feb 2009 21:31:39 -0000

Andrew Thompson wrote:
> Author: thompsa
> Date: Fri Feb 27 21:14:29 2009
> New Revision: 189123
> URL: http://svn.freebsd.org/changeset/base/189123
>
> Log:
>   Partial sync to //depot/projects/usb
>   
>   - Reissue the ctrl request on failure
>   - Ensure Tx and ctrl requests are not interleaved
>   - Add promisc callbacks
>   
>   Obtained from:	Hans Petter Selasky
>
>  
> +static void
> +rum_update_mcast(struct ifnet *ifp)
> +{
> +	/* not supported */
> +}
>   

This and similar additions for the other drivers are wrong.  They don't 
implement the functionality which means multicast filtering will be 
silently broken.  Drivers should only fill-in the callback if they do 
the work.  If someone were to fix IFF_ALLMULTI support then net80211 
could just fall back on it when drivers don't have or implement proper 
mcast filtering.

A cursory scan shows some odd changes in places like vap_delete but 
don't have time to look closely.  It appears the commit msg does not 
reflect the changes.

    Sam