Date: Thu, 8 Oct 2015 15:26:45 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Dmitry Marakasov <amdmi3@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r398821 - head/security/maia Message-ID: <20151008132645.GJ91729@ivaldir.etoilebsd.net> In-Reply-To: <201510081319.t98DJg1g056186@repo.freebsd.org> References: <201510081319.t98DJg1g056186@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--SLfjTIIQuAzj8yil Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 08, 2015 at 01:19:42PM +0000, Dmitry Marakasov wrote: > Author: amdmi3 > Date: Thu Oct 8 13:19:42 2015 > New Revision: 398821 > URL: https://svnweb.freebsd.org/changeset/ports/398821 >=20 > Log: > - Move file owner handling to plist, fix stage as non-root > =20 > PR: 203287 > Submitted by: amdmi3 > Approved by: maintainer timeout (ek@purplehat.org, 2 weeks) >=20 > Modified: > head/security/maia/Makefile > head/security/maia/pkg-plist >=20 > Modified: head/security/maia/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/security/maia/Makefile Thu Oct 8 12:56:37 2015 (r398820) > +++ head/security/maia/Makefile Thu Oct 8 13:19:42 2015 (r398821) > @@ -338,7 +338,6 @@ post-patch: > do-install: > ${MKDIR} ${STAGEDIR}${WWWDIR} > @cd ${WRKSRC}/php && ${COPYTREE_SHARE} . ${STAGEDIR}${WWWDIR} > - ${CHOWN} -R ${WWWOWN}:${WWWGRP} ${STAGEDIR}${WWWDIR}/ > ${LN} -s ${PREFIX}/share/smarty ${STAGEDIR}${WWWDIR}/libs/Smarty > ${MKDIR} -p ${STAGEDIR}${DATADIR} > @cd ${WRKSRC}/scripts && ${COPYTREE_SHARE} . ${STAGEDIR}${DATADIR}/scri= pts > @@ -350,11 +349,10 @@ do-install: > ${INSTALL} -m 640 ${WRKSRC}/maiad.conf.dist ${STAGEDIR}${ETCDIR}/maiad.= conf.dist > ${INSTALL} -m 640 ${WRKSRC}/maia.conf.dist ${STAGEDIR}${ETCDIR}/maia.co= nf.dist > =20 > -.if ${PORT_OPTIONS:MDOCS} > +do-install-DOCS-on: > ${MKDIR} ${STAGEDIR}${DOCSDIR} > .for i in ${DOCS} > ${INSTALL_DATA} ${WRKSRC}/${i} ${STAGEDIR}${DOCSDIR} > .endfor > -.endif > =20 > .include <bsd.port.post.mk> >=20 > Modified: head/security/maia/pkg-plist > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/security/maia/pkg-plist Thu Oct 8 12:56:37 2015 (r398820) > +++ head/security/maia/pkg-plist Thu Oct 8 13:19:42 2015 (r398821) > @@ -40,6 +40,8 @@ sbin/maiad > %%DATADIR%%/scripts/send-quarantine-reminders.pl > %%DATADIR%%/scripts/stats-snapshot.pl > @mode > +@owner %%WWWOWN%% > +@group %%WWWGRP%% There is absolutly no reason those files belongs to those users only direct= ories (like cache directories) and files that the app expect to be able to modifi= ed when run should be own by such user, otherwise everything should belong to root/wheel: aka the default Best regards, Bapt --SLfjTIIQuAzj8yil Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlYWbxUACgkQ8kTtMUmk6Ey94wCbBZkSUKslGBuLNP3sFU+Tmh9D n2YAoLszMDJY8NeEKWTD34dH2vjAdVcI =fRHb -----END PGP SIGNATURE----- --SLfjTIIQuAzj8yil--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20151008132645.GJ91729>