Date: Wed, 19 Apr 2023 20:29:52 +0000 From: Brooks Davis <brooks@freebsd.org> To: Hans Petter Selasky <hselasky@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: a7469c9c0a50 - main - libc: bsort_s() requires both __BSD_VISIBLE and __EXT1_VISIBLE Message-ID: <ZEBPQPzdmhhCNQ5I@spindle.one-eyed-alien.net> In-Reply-To: <202304192013.33JKDIrM070521@gitrepo.freebsd.org> References: <202304192013.33JKDIrM070521@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a formal request to revert all commits related to bsort. It should not have been committed without much broader discussion and IMO does not belong in the tree. It certainly should not be in the tree under such a generic name. -- Brooks On Wed, Apr 19, 2023 at 08:13:18PM +0000, Hans Petter Selasky wrote: > The branch main has been updated by hselasky: >=20 > URL: https://cgit.FreeBSD.org/src/commit/?id=3Da7469c9c0a504a5e6e9b89e148= cd78df5e67ff7f >=20 > commit a7469c9c0a504a5e6e9b89e148cd78df5e67ff7f > Author: Hans Petter Selasky <hselasky@FreeBSD.org> > AuthorDate: 2023-04-19 19:37:29 +0000 > Commit: Hans Petter Selasky <hselasky@FreeBSD.org> > CommitDate: 2023-04-19 20:12:04 +0000 >=20 > libc: bsort_s() requires both __BSD_VISIBLE and __EXT1_VISIBLE > =20 > Fixes build of Python: > /usr/include/stdlib.h:409:1: error: unknown type name 'errno_t' > errno_t bsort_s(void *, rsize_t, rsize_t, > =20 > Reported by: vishwin@ > MFC after: 1 week > Sponsored by: NVIDIA Networking > Differential Revision: https://reviews.freebsd.org/D36493 > --- > include/stdlib.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/include/stdlib.h b/include/stdlib.h > index 857092b9053e..3ad28cf68847 100644 > --- a/include/stdlib.h > +++ b/include/stdlib.h > @@ -403,12 +403,12 @@ void ignore_handler_s(const char * __restrict, void= * __restrict, errno_t); > /* K.3.6.3.2 */ > errno_t qsort_s(void *, rsize_t, rsize_t, > int (*)(const void *, const void *, void *), void *); > -#endif /* __EXT1_VISIBLE */ > =20 > #if __BSD_VISIBLE > errno_t bsort_s(void *, rsize_t, rsize_t, > int (*)(const void *, const void *, void *), void *); > #endif /* __BSD_VISIBLE */ > +#endif /* __EXT1_VISIBLE */ > =20 > __END_DECLS > __NULLABILITY_PRAGMA_POP >=20
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZEBPQPzdmhhCNQ5I>