From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Apr 2 16:10:12 2010 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EE78D1065674 for ; Fri, 2 Apr 2010 16:10:11 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id AB24B8FC14 for ; Fri, 2 Apr 2010 16:10:11 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o32GABMn040210 for ; Fri, 2 Apr 2010 16:10:11 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o32GABMd040209; Fri, 2 Apr 2010 16:10:11 GMT (envelope-from gnats) Resent-Date: Fri, 2 Apr 2010 16:10:11 GMT Resent-Message-Id: <201004021610.o32GABMd040209@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Toomas Aas Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B1809106566C for ; Fri, 2 Apr 2010 16:02:26 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 863EE8FC13 for ; Fri, 2 Apr 2010 16:02:26 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o32G2PJf011011 for ; Fri, 2 Apr 2010 16:02:25 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id o32G2PQ0011010; Fri, 2 Apr 2010 16:02:25 GMT (envelope-from nobody) Message-Id: <201004021602.o32G2PQ0011010@www.freebsd.org> Date: Fri, 2 Apr 2010 16:02:25 GMT From: Toomas Aas To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/145295: www/ruby-cruisecontrolrb installs a non-working rc.d script X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Apr 2010 16:10:12 -0000 >Number: 145295 >Category: ports >Synopsis: www/ruby-cruisecontrolrb installs a non-working rc.d script >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Apr 02 16:10:11 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Toomas Aas >Release: 6.4 >Organization: >Environment: FreeBSD mail.tarkvarastuudio.ee 6.4-RELEASE-p4 FreeBSD 6.4-RELEASE-p4 #2: Tue Oct 13 08:03:57 EEST 2009 toomas@mail.tarkvarastuudio.ee:/usr/obj/usr/src/sys/TVS amd64 >Description: After installing the www/ruby-cruisecontrolrb port, setting cruisecontrolrb_enable="YES" in /etc/rc.conf and issuing the command /usr/local/etc/rc.d/cruisecontrolrb start, the process does not start. It seems to me that there are three problems with the script: 1. The script does not have the run_rc_command line; 2. There is a typo on line 28 ("curisecontrol" instead of "cruisecontrol", causing invalid arguments being passed to the start command; 3. 'stop' is not a valid argument for the cruise command, which means that stop command does not stop the daemon, giving an error message instead. >How-To-Repeat: Install the www/ruby-cruisecontrolrb port and try running the supplied rc.d script: /usr/local/etc/rc.d/cruisecontrolrb start >Fix: Replace the port-supplied script with the following: #!/bin/sh # PROVIDE: cruisecontrolrb # REQUIRE: DAEMON # KEYWORD: shutdown # # This script is modified by placing the following variables inside # /etc/rc.conf.local, /etc/rc.conf, or /etc/rc.conf.d/cruisecontrolrb: # # cruisecontrolrb_enable (bool): # Set it to YES to enable this service. # Default: NO # cruisecontrolrb_port (port): # Set it to a port # Default: 3333 . /etc/rc.subr name=cruisecontrolrb rcvar=${name}_enable pidfile="/usr/local/www/cruisecontrolrb/tmp/pids/mongrel.pid" command="/usr/local/www/cruisecontrolrb/cruise" load_rc_config $name : ${cruisecontrolrb_enable="NO"} : ${cruisecontrolrb_port="3333"} command_args="-p ${cruisecontrolrb_port}" start_cmd="cruisecontrolrb_cmd start" stop_cmd="cruisecontrolrb_cmd stop" cruisecontrolrb_cmd() { case $1 in start) command_args="${command_args} -d" ${command} $1 ${command_args} ;; stop) kill `cat $pidfile` ;; esac } run_rc_command "$1" >Release-Note: >Audit-Trail: >Unformatted: