From owner-cvs-all@FreeBSD.ORG Thu Jul 15 18:55:22 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 422D716A4CF for ; Thu, 15 Jul 2004 18:55:22 +0000 (GMT) Received: from mail1.speakeasy.net (mail1.speakeasy.net [216.254.0.201]) by mx1.FreeBSD.org (Postfix) with ESMTP id 18AE343D54 for ; Thu, 15 Jul 2004 18:55:22 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 24894 invoked from network); 15 Jul 2004 18:55:21 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 15 Jul 2004 18:55:21 -0000 Received: from 10.50.41.229 (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id i6FItFGp083239; Thu, 15 Jul 2004 14:55:18 -0400 (EDT) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Mark Santcroos Date: Thu, 15 Jul 2004 14:18:01 -0400 User-Agent: KMail/1.6 References: <200406231508.i5NF8egh052377@repoman.freebsd.org> <200406231122.04154.jhb@FreeBSD.org> <20040715161403.GA741@laptop.6bone.nl> In-Reply-To: <20040715161403.GA741@laptop.6bone.nl> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200407151418.01839.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/acpica acpi_pci.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Jul 2004 18:55:22 -0000 On Thursday 15 July 2004 12:14 pm, Mark Santcroos wrote: > On Wed, Jun 23, 2004 at 11:22:04AM -0400, John Baldwin wrote: > > On Wednesday 23 June 2004 11:08 am, John Baldwin wrote: > > > jhb 2004-06-23 15:08:40 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/dev/acpica acpi_pci.c > > > Log: > > > Now that we associate a device_t with ACPI device handles, lookup the > > > device associated with any PCI devices that are enumerated in the > > > ACPI tree when adding children to an ACPI PCI bus and remove the > > > duplicate ACPI-only device_t and replace the device_t associated with > > > the handle with the ACPI and PCI aware device_t. > > > > Mostly this just means fewer unknown devices in devinfo -v output. > > You forgot to mention that this commit breaks acpi_video ;-) > > The fact that "\_SB_.PCI0.AGP_.VID_" now no longer is "unknown", means that > it is not probed anymore. > > The result of that is that acpi_video can't attach anymore of course. That's because acpi_video is really a PCI driver. :) The device it is attaching too is a PCI device, not an ACPI device, hence the confusion. I have some early work started on a vga_pci driver that would have child devices like acpi_video0, drm0, agp0 (for Intel onboard graphics), and dpms0. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org