From nobody Fri Jun 17 11:13:03 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 2A552844224 for ; Fri, 17 Jun 2022 11:13:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LPbxW6YhPz4q53 for ; Fri, 17 Jun 2022 11:13:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id C180E1E56F for ; Fri, 17 Jun 2022 11:13:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 25HBD3nO041041 for ; Fri, 17 Jun 2022 11:13:03 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 25HBD3wR041040 for bugs@FreeBSD.org; Fri, 17 Jun 2022 11:13:03 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 253912] [PATCH] Inefficient lookup of incoming packets in libalias Date: Fri, 17 Jun 2022 11:13:03 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: 8an@praha12.net X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1655464384; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ObWhfOYvEEOat6JgCGf5YnFcP6OlTRpVfkTTsGZvcsw=; b=psEvwuGpCQlsP+LIbmK7XzHCpJ36/vl17++oeDWtlmPUfNbeaqAoiN+/AbuSNxBIhjScM5 sqHd+LWFKWzS8+AtRNG6KhbeqbY6OUdu5D9rn5DAllpwNGKIdAsXEXQXDsTdv+zSi+kX9n MzvGhTNv0WurcLgbtx6JFxf9Qr2BMmihKPOj1LHDuul4eHRfXYimy+hw9MsHAAgxxndA2s OWz6f2fIwTAN/aMWs1jddytkUAubhB1SjF6veRwOao/TSztaubK0IcAP9htPQfWD0X5hYy VsvR+GFJcpWIpgshLDfznPx9HuqPDuesoGTYzttphC0C4FMkb63ZAROLzCHejw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1655464384; a=rsa-sha256; cv=none; b=YnOXcwEiNQCfj+gbz3uX3WdM9BlSS7PPnt1tta5Ux9Hd2qQ7SudrFkSgahTTQuBDbSj1PY e2Pn7cdTz0SsFSxyXWjn6er2REruq61sq0tZ4Xr2RkvJp3Be0clrbl0/jAYiXQW8oLNQAI zU1CeTzKwxr8FcIlWpcEc7x5xhIODrbrKVnugln01st2mWbM3/YVLb0RM2oBz6hpxFHTWJ XF2LCXaFNyhuuz8QMGMg3kII/Sr/hqgrh9DzMl41J2OdZZP0bU5foC8GPETMgWvd7HdA3/ iRTlq7GGuYlsB72qe+I7sN6t2Wjw0e7Y5Wpt17Yk1cuDTBdRleDjgU/wrLDJuQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253912 --- Comment #1 from Lukas Turek <8an@praha12.net> --- Even though libalias database was mostly rewriten, this bug is still presen= t in 13.1. The problem wasn't in the data structure itself (hash table or splay tree), but in the key used for lookup. If the key contains only alias addre= ss and port, all packets from many addresses in DDoS targeting the same local address and port will collide in a single entry. I made a new patch working= in a similar way to the previous one. I did some simple tests, but we haven't deployed it in production yet. --=20 You are receiving this mail because: You are the assignee for the bug.=