From owner-freebsd-net@FreeBSD.ORG Tue Sep 8 13:13:12 2009 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 31224106566C for ; Tue, 8 Sep 2009 13:13:12 +0000 (UTC) (envelope-from bms@incunabulum.net) Received: from out1.smtp.messagingengine.com (out1.smtp.messagingengine.com [66.111.4.25]) by mx1.freebsd.org (Postfix) with ESMTP id 02B308FC08 for ; Tue, 8 Sep 2009 13:13:11 +0000 (UTC) Received: from compute2.internal (compute2.internal [10.202.2.42]) by gateway1.messagingengine.com (Postfix) with ESMTP id 3446968E5E; Tue, 8 Sep 2009 09:13:10 -0400 (EDT) Received: from heartbeat1.messagingengine.com ([10.202.2.160]) by compute2.internal (MEProxy); Tue, 08 Sep 2009 09:13:10 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=messagingengine.com; h=message-id:date:from:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding; s=smtpout; bh=poFZRoXmtyh0QZ3nhD1ZtWRN5pE=; b=KS1hAdy6MbvoYNB50kFiXvFhIQZcipY2Vi490/3amq8KoXSxZ1Mk/VjHEVBjvpL2/k+UcAxWBmxSEAVFZWheLk9RifAXXH5pFnNw0x3ERTQBH3fKggFLoihXRRXbpTw06wY76vkaX0N+MReXl81B0t/kq2EwjW/14mPjdi7UKq0= X-Sasl-enc: 5s75L+GwyIJMr4h3A0w/VDbIwc1VdkFLTXZ/vN2mwuY9 1252415589 Received: from [192.168.123.18] (82-35-112-254.cable.ubr07.dals.blueyonder.co.uk [82.35.112.254]) by mail.messagingengine.com (Postfix) with ESMTPSA id B19016812D; Tue, 8 Sep 2009 09:13:09 -0400 (EDT) Message-ID: <4AA65861.8@incunabulum.net> Date: Tue, 08 Sep 2009 14:13:05 +0100 From: Bruce Simpson User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: stef@memberwebs.com References: <4AA65663.8050106@incunabulum.net> In-Reply-To: <4AA65663.8050106@incunabulum.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "freebsd-net@FreeBSD.org" Subject: Re: Panic in imo_match_source (netinet/in_mcast.c) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Sep 2009 13:13:12 -0000 [Brief reply as I'm meant to be doing a zillion other things...] Bruce Simpson wrote: > > Full OS version, dmesg, panic and backtrace please, when reporting > this kind of issue... otherwise folk can't help. Are you using SSM > multicast features? P.S. You might want to try demoting the KASSERT to a conditional error return (return no match if src is NULL or src->sa_family != AF_INET), and see if that fix 'just works' for you. Sometimes the asserts I sprinkle into code are too paranoid for what's going on, and syrinx@ recently caught one of those. I can see some situations where this could kick off, so that is probably the right fix. Please do let me know. If that fix works for you then it can probably be checked in. There is an RC cutoff looming, so if I can't do it in time, someone else may be able to check it in. thanks, BMS