From owner-freebsd-current@freebsd.org Mon Apr 5 10:01:06 2021 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id EDABE5B15DF for ; Mon, 5 Apr 2021 10:01:06 +0000 (UTC) (envelope-from guyyur@gmail.com) Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FDR4f0Lqnz3ntK; Mon, 5 Apr 2021 10:01:05 +0000 (UTC) (envelope-from guyyur@gmail.com) Received: by mail-ej1-x62b.google.com with SMTP id r12so16095131ejr.5; Mon, 05 Apr 2021 03:01:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:subject:to:message-id:date:user-agent:mime-version :content-transfer-encoding:content-language; bh=hnU+E9G+GFOxMo6cju5NgN1SIw37nR8eGEwmcc3tgN4=; b=ALNR/LoN0hjYfxvyCdr8NybLeFai47M1Wwlt4UgeE7Sbp4j+bU4vgXqJ6/A1+3zoeg aDiGFDqREJO45V+e2HJa6qLLhwOdMkkDmLYUIC1xo+e+PNK7a0egBgn+m9fMPJMWXTNy rDeMbTbAPGhHGDAQMzc1doQcf4rShUBVv9VQv2AFnagwUx7S56GV4p8eawCUFOW613rK 0PcGpKP2ukR2s9jYioKWRZ9SCUHa/avAC9d2QbkUMCGIQ32vwHczQW4eNGNi2PYnFsSL CtxChKo+pO6k2T21Li1uU4OK3SBjZDokLYItpBKGzNLkrHLKCagur4i5JSOfPDfk5Zjx NEQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:message-id:date:user-agent :mime-version:content-transfer-encoding:content-language; bh=hnU+E9G+GFOxMo6cju5NgN1SIw37nR8eGEwmcc3tgN4=; b=JKYrEoHN0h3D/QAVLvVBBZA8Ou2EiWl5iMIgJqMznwmFHFEv8HfDKKOtZ3JNb0Qpm5 mEQ8uDogHk2GVWLnQ+L70i2fvDhTptAl1eNAKRLdsczqfXhg+W0lEiPe2GU2+0hlwuZI gEQIID4S0Se5ZRirtr/VYPIYadDtgo5hzbFZn51wnb6f0nPbTEw5XUxkNIBdh6J3xTYm d/gMqADOeGiCz/RTfLqcljT/pSnwffsuVkm9O3kg7w67VVZGYW8mB+hxAQOHcgNBUtdQ WHl8ymaZoQ6IaOVtiVyD7raLvAWVTCDphW+KHkl7NIHFa+BSILaWXSCS2j0AVsolhP9O vz8Q== X-Gm-Message-State: AOAM530Iw3vtFTAxVtFXttglkXZBcFirp03Yk3sbQ6AzVNqpyozL3qOC QRkl3j7XRaLGLvbOzt2FwkmPOuxwriSmfAj9 X-Google-Smtp-Source: ABdhPJza0aamdjnMyQbg6iBHjhDW/LpQ1Mze/QkCyryN4ihJX4dGHroEC0mf9R8IzOwKtsEh7WiVLQ== X-Received: by 2002:a17:906:fa93:: with SMTP id lt19mr4334785ejb.182.1617616863976; Mon, 05 Apr 2021 03:01:03 -0700 (PDT) Received: from ?IPv6:2a0d:6fc2:51d1:4e01:bcf5:f36:a8b7:7810? ([2a0d:6fc2:51d1:4e01:bcf5:f36:a8b7:7810]) by smtp.gmail.com with ESMTPSA id w13sm4205622edc.81.2021.04.05.03.01.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Apr 2021 03:01:03 -0700 (PDT) From: Guy Yur Subject: no message of the day displayed by login after reboot when update_motd="NO" To: cem@FreeBSD.org, delphij@FreeBSD.org, freebsd-current Message-ID: <06864cb5-24f3-3f94-6d95-7120ba202404@gmail.com> Date: Mon, 5 Apr 2021 13:01:02 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Rspamd-Queue-Id: 4FDR4f0Lqnz3ntK X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=ALNR/LoN; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of guyyur@gmail.com designates 2a00:1450:4864:20::62b as permitted sender) smtp.mailfrom=guyyur@gmail.com X-Spamd-Result: default: False [-2.21 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RBL_DBL_DONT_QUERY_IPS(0.00)[2a00:1450:4864:20::62b:from]; FREEMAIL_ENVFROM(0.00)[gmail.com]; MID_RHS_MATCH_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; NEURAL_SPAM_SHORT(0.79)[0.788]; SPAMHAUS_ZRD(0.00)[2a00:1450:4864:20::62b:from:127.0.2.255]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::62b:from]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[freebsd-current] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Apr 2021 10:01:07 -0000 Hi, login doesn't display the message of the day when update_motd="NO" after the change to read /var/run/motd instead of /etc/motd. When update_motd="NO": If you create /var/run/motd manually it will be deleted by cleanvar rc script after a reboot. If you keep /var/run as tmpfs nothing creates /var/run/motd. I updated bug 250081 that issue also exists for /var/run that is not tmpfs. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=250081 My latest fix attempt was in motd rc script by copying motd.template if motd doesn't exist to solve the /var/run as tmpfs and first install issues, but I didn't know cleanvar also deletes the file, so I don't think it is a good solution for /var/run that is not tmpfs. https://reviews.freebsd.org/D26654 I think reverting /etc/motd change in login(1) and login.conf as suggested in https://reviews.freebsd.org/D26654#610447 is better. motd script will still need modification to always create ${COMPAT_MOTD} symlink.  Otherwise, if template already exists, ${COMPAT_MOTD} won't be created and login(1) will not find /etc/motd. I think documentation changes are also required for update_motd="NO" case as was done in second diff: https://reviews.freebsd.org/D26654?id=78733 Regards, Guy Yur