From owner-svn-src-all@FreeBSD.ORG Thu Feb 24 23:11:49 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 329A3106566B; Thu, 24 Feb 2011 23:11:49 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id EBFE58FC16; Thu, 24 Feb 2011 23:11:47 +0000 (UTC) Received: by wwb31 with SMTP id 31so1455868wwb.31 for ; Thu, 24 Feb 2011 15:11:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=HhHy3j0DGflH99e+pbSZNmvaXXnlkIIDrkSFUEk40yg=; b=qfZaOi6qxxXnyxNExefO0WSKv87MVA7ivCjly6SdCuDetCYwC0H1mICNAEbbbraKBk w/utvhAM7ay7y8LBe4tuRwjvzLdqG0/JezkkbJ5yzwSeXfZI0Hk9mMcffwQdHB/ROreq nbOscrKUVtczjMvsVOSRViIb6Z9faKhbvcMss= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=YsXl17Gp3jwJkRnN1YKBoewcayQ/ItovcJ6BI1MAl0UOrphqto+kKmMUqFWWzsnOW9 XYC6t4BYORCd44S0ucreXEogQzDuKefAOpKxoGNxW6hNVqTC2YYDnsyWOTwlClD9I/uw PDXEzbUUM3W87GMkCTN+idrzriWnXyTHkdhDs= MIME-Version: 1.0 Received: by 10.216.162.70 with SMTP id x48mr6517727wek.4.1298589106910; Thu, 24 Feb 2011 15:11:46 -0800 (PST) Sender: yanegomi@gmail.com Received: by 10.216.15.74 with HTTP; Thu, 24 Feb 2011 15:11:46 -0800 (PST) In-Reply-To: <20110224144303.baa6e809.stas@FreeBSD.org> References: <201102220513.p1M5DRrQ095042@svn.freebsd.org> <20110224144303.baa6e809.stas@FreeBSD.org> Date: Thu, 24 Feb 2011 15:11:46 -0800 X-Google-Sender-Auth: AUmIZLZkmOOx1hkz0F-t3yjJ0tM Message-ID: From: Garrett Cooper To: Stanislav Sedov Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, rwatson@freebsd.org, Martin Wilke Subject: Re: svn commit: r218938 - head/tools/regression/aio/kqueue X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Feb 2011 23:11:49 -0000 On Thu, Feb 24, 2011 at 2:43 PM, Stanislav Sedov wrote: > On Tue, 22 Feb 2011 05:13:27 +0000 (UTC) > Martin Wilke mentioned: > >> Author: miwi >> Date: Tue Feb 22 05:13:26 2011 >> New Revision: 218938 >> URL: http://svn.freebsd.org/changeset/base/218938 >> >> Log: >> =A0 - Fix QA issues >> > > What kind these QA issues are of? Stupid me. This was wrong: - char *file, pathname[sizeof(PATH_TEMPLATE)-1]; + char *file, pathname[sizeof(PATH_TEMPLATE)+1]; (sizeof will return the buffer size -- the above item was true if I was using strlen) NULL pointer derefs: + iocb[i] =3D (struct aiocb *)calloc(1, + sizeof(struct aiocb)); + if (iocb[i] =3D=3D NULL) + err(1, "calloc"); Memory leaks: + for (i =3D 0; i < MAX; i++) + free(iocb[i]); + > Also, style(9) does not encourage extra bland lines for now reason. Sorry .. the blank lines for my mistake :(... Thanks, -Garrett