From owner-svn-src-head@FreeBSD.ORG  Sun Oct  7 13:27:08 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 3A4AB106564A;
	Sun,  7 Oct 2012 13:27:08 +0000 (UTC)
	(envelope-from simon@FreeBSD.org)
Received: from emx.nitro.dk (leto.nitro.dk [178.63.52.6])
	by mx1.freebsd.org (Postfix) with ESMTP id E43E98FC23;
	Sun,  7 Oct 2012 13:27:07 +0000 (UTC)
Received: from mailscan.leto.nitro.dk (mailscan.leto.nitro.dk [127.0.1.4])
	by emx.nitro.dk (Postfix) with ESMTP id C0A5F30F10C;
	Sun,  7 Oct 2012 13:27:00 +0000 (UTC)
Received: from emx.nitro.dk ([127.0.1.2])
	by mailscan.leto.nitro.dk (mailscan.leto.nitro.dk [127.0.1.4])
	(amavisd-new, port 10024)
	with LMTP id Xz8OiCQsfejt; Sun,  7 Oct 2012 13:26:58 +0000 (UTC)
Received: from [192.168.4.24] (unknown [89.100.2.68])
	(using TLSv1 with cipher AES128-SHA (128/128 bits))
	(No client certificate requested)
	by emx.nitro.dk (Postfix) with ESMTPSA id 4824530F102;
	Sun,  7 Oct 2012 13:26:58 +0000 (UTC)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 6.2 \(1499\))
From: "Simon L. B. Nielsen" <simon@FreeBSD.org>
In-Reply-To: <201210021744.q92Hi8dt077996@svn.freebsd.org>
Date: Sun, 7 Oct 2012 14:26:57 +0100
Content-Transfer-Encoding: quoted-printable
Message-Id: <FA478B4F-9FE3-4928-A3C8-BC14417C5603@FreeBSD.org>
References: <201210021744.q92Hi8dt077996@svn.freebsd.org>
To: Andrey A. Chernov <ache@FreeBSD.org>
X-Mailer: Apple Mail (2.1499)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r241137 - head/lib/libc/stdlib
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 07 Oct 2012 13:27:08 -0000


On 2 Oct 2012, at 18:44, Andrey A. Chernov <ache@FreeBSD.org> wrote:

> Author: ache
> Date: Tue Oct  2 17:44:08 2012
> New Revision: 241137
> URL: http://svn.freebsd.org/changeset/base/241137
>=20
> Log:
>  Using putenv() and later direct pointer contents modification it is =
possibe
>  to craft environment variables with similar names like that:
>  a=3D1
>  a=3D2
>  ...
>  unsetenv("a") should remove them all to make later getenv("a") =
impossible.
>  Fix it to do so (this is GNU autoconf test #3 failure too).
>=20
>  PR:             172273
>  MFC after:      1 week
>=20
> Modified:
>  head/lib/libc/stdlib/getenv.c

Reviewed by ?

This needs to be reviewed by someone with clue about the pittfals if =
environment manipulation before any MFC.

PS. env functions are mentioned in MAINTAINERS.

--=20
Simon L. B. Nielsen
FreeBSD Security Officer