Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 6 Dec 2021 21:39:46 GMT
From:      John Baldwin <jhb@FreeBSD.org>
To:        ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org
Subject:   git: 2762292fc4cf - main - devel/gdb: Fix kernel backend registrations.
Message-ID:  <202112062139.1B6Ldkw0094396@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by jhb (doc, src committer):

URL: https://cgit.FreeBSD.org/ports/commit/?id=2762292fc4cfa22b905389a57d17453554e1eeab

commit 2762292fc4cfa22b905389a57d17453554e1eeab
Author:     John Baldwin <jhb@FreeBSD.org>
AuthorDate: 2021-12-06 21:38:04 +0000
Commit:     John Baldwin <jhb@FreeBSD.org>
CommitDate: 2021-12-06 21:38:04 +0000

    devel/gdb: Fix kernel backend registrations.
    
    Per-architecture kernel backends are registered via GDB initialization
    routines.  The GDB build uses a regular expression to identify the
    initialization routines invoked during startup.  This regular
    expression requires a single space between the function name and it's
    empty argument list.  However, the initializers for aarch64, arm,
    mips, and riscv had two spaces before the empty argument list causing
    those backends to not be registered and the corresponding architecture
    kernels to not be recognized.  Fix by removing the spurious spaces.
    
    Reported by:    kevans
    Reviewed by:    pizzamig (maintainer)
    Differential Revision:  https://reviews.freebsd.org/D33255
---
 devel/gdb/Makefile                       | 2 +-
 devel/gdb/files/kgdb/aarch64-fbsd-kern.c | 2 +-
 devel/gdb/files/kgdb/arm-fbsd-kern.c     | 2 +-
 devel/gdb/files/kgdb/mipsfbsd-kern.c     | 2 +-
 devel/gdb/files/kgdb/riscv-fbsd-kern.c   | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/devel/gdb/Makefile b/devel/gdb/Makefile
index 66abc21d8070..ce27f4e7b213 100644
--- a/devel/gdb/Makefile
+++ b/devel/gdb/Makefile
@@ -2,7 +2,7 @@
 
 PORTNAME=	gdb
 DISTVERSION=	11.1
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	devel
 MASTER_SITES=	GNU
 
diff --git a/devel/gdb/files/kgdb/aarch64-fbsd-kern.c b/devel/gdb/files/kgdb/aarch64-fbsd-kern.c
index 8c0bac8dfc0b..6cdbb66397b0 100644
--- a/devel/gdb/files/kgdb/aarch64-fbsd-kern.c
+++ b/devel/gdb/files/kgdb/aarch64-fbsd-kern.c
@@ -189,7 +189,7 @@ aarch64_fbsd_kernel_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
 
 void _initialize_aarch64_kgdb_tdep ();
 void
-_initialize_aarch64_kgdb_tdep  ()
+_initialize_aarch64_kgdb_tdep ()
 {
   gdbarch_register_osabi_sniffer(bfd_arch_aarch64,
 				 bfd_target_elf_flavour,
diff --git a/devel/gdb/files/kgdb/arm-fbsd-kern.c b/devel/gdb/files/kgdb/arm-fbsd-kern.c
index 4ae80313dbc3..552c3a95a257 100644
--- a/devel/gdb/files/kgdb/arm-fbsd-kern.c
+++ b/devel/gdb/files/kgdb/arm-fbsd-kern.c
@@ -201,7 +201,7 @@ arm_fbsd_kernel_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
 
 void _initialize_arm_kgdb_tdep ();
 void
-_initialize_arm_kgdb_tdep  ()
+_initialize_arm_kgdb_tdep ()
 {
   gdbarch_register_osabi_sniffer(bfd_arch_arm,
 				 bfd_target_elf_flavour,
diff --git a/devel/gdb/files/kgdb/mipsfbsd-kern.c b/devel/gdb/files/kgdb/mipsfbsd-kern.c
index 78c9c44a2ca4..303473e543c5 100644
--- a/devel/gdb/files/kgdb/mipsfbsd-kern.c
+++ b/devel/gdb/files/kgdb/mipsfbsd-kern.c
@@ -284,7 +284,7 @@ mipsfbsd_kernel_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
 
 void _initialize_mips_kgdb_tdep ();
 void
-_initialize_mips_kgdb_tdep  ()
+_initialize_mips_kgdb_tdep ()
 {
   gdbarch_register_osabi_sniffer(bfd_arch_mips,
 				 bfd_target_elf_flavour,
diff --git a/devel/gdb/files/kgdb/riscv-fbsd-kern.c b/devel/gdb/files/kgdb/riscv-fbsd-kern.c
index 5d648fd0db83..ebdead34c2b4 100644
--- a/devel/gdb/files/kgdb/riscv-fbsd-kern.c
+++ b/devel/gdb/files/kgdb/riscv-fbsd-kern.c
@@ -195,7 +195,7 @@ riscv_fbsd_kernel_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
 
 void _initialize_riscv_kgdb_tdep ();
 void
-_initialize_riscv_kgdb_tdep  ()
+_initialize_riscv_kgdb_tdep ()
 {
   gdbarch_register_osabi_sniffer(bfd_arch_riscv,
 				 bfd_target_elf_flavour,



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202112062139.1B6Ldkw0094396>