From owner-cvs-src@FreeBSD.ORG Mon Oct 4 16:37:02 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9277C16A4CF; Mon, 4 Oct 2004 16:37:02 +0000 (GMT) Received: from harmony.village.org (rover.village.org [168.103.84.182]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3023843D53; Mon, 4 Oct 2004 16:37:02 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (harmony.village.org [10.0.0.6]) by harmony.village.org (8.13.1/8.13.1) with ESMTP id i94GZ5fu092281; Mon, 4 Oct 2004 10:35:05 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Mon, 04 Oct 2004 10:36:38 -0600 (MDT) Message-Id: <20041004.103638.70543632.imp@bsdimp.com> To: des@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <200410041126.i94BQ273055417@repoman.freebsd.org> References: <200410041126.i94BQ273055417@repoman.freebsd.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/rm rm.1 rm.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Oct 2004 16:37:02 -0000 In message: <200410041126.i94BQ273055417@repoman.freebsd.org> Dag-Erling Smorgrav writes: : des 2004-10-04 11:26:02 UTC : 1.30 +2 -1 src/bin/rm/rm.1 : 1.49 +23 -0 src/bin/rm/rm.c I contend that this change is technically flawed. While it is allowed by the standards, I believe we should exit entirely when we hit this 'third rail' rather than just ignoring the offending arg. If it is there as a sanity check, and you hit it, you can't assume that the rest of the arguments are sane at all. This is fundamentally different than the '.' checks, which do remove the bad args from the list and aren't likely the results of an error. All the other points I was going to make, actually are handled well: exit values are correct looks for them all before doing anything style(9) is ok escape hatch (rm -rf // will do it) etc So from a technical point of view, my opinion is that the only error in this commit is a warn(...) where there should be an errx(1, ...). Warner