From owner-freebsd-bugs@FreeBSD.ORG Sun Jun 15 08:51:48 2014 Return-Path: Delivered-To: freebsd-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6C6F6B0D for ; Sun, 15 Jun 2014 08:51:48 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3A0902062 for ; Sun, 15 Jun 2014 08:51:48 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.8/8.14.8) with ESMTP id s5F8pm53039380 for ; Sun, 15 Jun 2014 09:51:48 +0100 (BST) (envelope-from bz-noreply@freebsd.org) From: bz-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 191056] New: bsd.progs.mk: bsd.prog.mk incompatibilities with variables being set and not set Date: Sun, 15 Jun 2014 08:51:48 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: misc X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: yaneurabeya@gmail.com X-Bugzilla-Status: Needs Triage X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jun 2014 08:51:48 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191056 Bug ID: 191056 Summary: bsd.progs.mk: bsd.prog.mk incompatibilities with variables being set and not set Product: Base System Version: 11.0-CURRENT Hardware: Any OS: Any Status: Needs Triage Severity: Affects Some People Priority: --- Component: misc Assignee: freebsd-bugs@FreeBSD.org Reporter: yaneurabeya@gmail.com There are some values where, if unset in bsd.prog.mk, would default to the .. For instance if I had a Makefile that defined a program a, like so... % cat * # Makefile PROG= a .include /* a.c */ #include int main(void) { printf("hello world\n"); return (0); } % make all Warning: Object directory not changed from original /root/make_tests/prog_mk cc -O2 -pipe -std=gnu99 -fstack-protector -Qunused-arguments -c a.c cc -O2 -pipe -std=gnu99 -fstack-protector -Qunused-arguments -o a a.o make: don't know how to make a.1. Stop make: stopped in /root/make_tests/prog_mk % As shown above, bsd.prog.mk automatically assumes that there was a corresponding source file for ;a' called 'a.c', and there's a manpage a.1. bsd.progs.mk doesn't maintain this compatibility because it passes through several variables with empty values instead of not passing them through in the first place. Example: % cat * # Makefile PROGS= a .include /* a.c */ #include int main(void) { printf("hello world!\n"); return (0); } % make all (cd /root/make_tests/progs_mk && make -f Makefile _RECURSING_PROGS= SUBDIR= PROG=a ) Warning: Object directory not changed from original /root/make_tests/progs_mk make[1]: don't know how to make .o. Stop make[1]: stopped in /root/make_tests/progs_mk *** Error code 2 Stop. make: stopped in /root/make_tests/progs_mk Expected result: - The following variables should not be passed through if they aren't set: -- BINDIR -- MAN -- SRCS There might be more, but these are definite issues that I've found when testing out bsd.progs.mk over the past couple months. My diff against bsd.progs.mk is attached as a reference for how I "fixed" the problem. -- You are receiving this mail because: You are the assignee for the bug.