From owner-freebsd-stable@FreeBSD.ORG Tue Jan 18 17:51:14 2011 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 430D71065693; Tue, 18 Jan 2011 17:51:14 +0000 (UTC) (envelope-from pluknet@gmail.com) Received: from mail-qw0-f54.google.com (mail-qw0-f54.google.com [209.85.216.54]) by mx1.freebsd.org (Postfix) with ESMTP id C2F4F8FC17; Tue, 18 Jan 2011 17:51:13 +0000 (UTC) Received: by qwj9 with SMTP id 9so5888388qwj.13 for ; Tue, 18 Jan 2011 09:51:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=/tNBfBVK8+KCrlzdBGUOXfN3MawQnvRDmgqlzwBBHUM=; b=vwRJIOUpSIjoeZ3pc4WWPfKglXZ/a07/umPYjgKcZzm49K7E39nfYGixXkJTeCKSAR rYDl6tiIsQcRjhS5nXI9C8yHQx/CQeETiAJ2s1r00YmudUgksJv9IOEhuepr4RDbZ3zA Kreji53aFyQpuoasJTCZen16u/rFHZBNu/Ew4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=bov0PaTbmf3ex5BAkJa7IMKiCABmf3yB/7vNs5zNFOXHr4kkXSqPPjr8UKW5G0s7QT YUzTum+N0hiyVscz/FtW/vBtCDdhhzh8y/2j9bubfLnNee09U341FShOg0ldDmOD7o1w VI+vxhX2i3/P6ep8MhORJgqHkMSzUtpExpvg0= MIME-Version: 1.0 Received: by 10.229.248.198 with SMTP id mh6mr5107904qcb.5.1295373072760; Tue, 18 Jan 2011 09:51:12 -0800 (PST) Received: by 10.229.102.87 with HTTP; Tue, 18 Jan 2011 09:51:12 -0800 (PST) In-Reply-To: <201101181119.42053.jhb@freebsd.org> References: <4cfc72a5.3nAjkv8mdrO/NrKQ%perryh@pluto.rain.com> <4d3261bc.dcI6EuBnzRqvyRnz%perryh@pluto.rain.com> <201101181119.42053.jhb@freebsd.org> Date: Tue, 18 Jan 2011 20:51:12 +0300 Message-ID: From: Sergey Kandaurov To: John Baldwin Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: perryh@pluto.rain.com, freebsd-stable@freebsd.org, avg@freebsd.org Subject: Re: Could MSGBUF_SIZE be made a loader tunable? X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jan 2011 17:51:14 -0000 On 18 January 2011 19:19, John Baldwin wrote: > On Sunday, January 16, 2011 12:24:27 pm Sergey Kandaurov wrote: >> On 16 January 2011 06:10, =A0 wrote: >> > Anyone had a chance to look at this? >> > >> > http://lists.freebsd.org/pipermail/freebsd-stable/2010-December/060793= .html >> >> To ease testing on head I have regenerated the patch >> (against r216594): >> http://plukky.net/~pluknet/patches/msgbufsize.diff > > The one hunk involving tf_rip and PS_STRINGS in amd64 looks to be unrelat= ed. Woops, sorry. Nice catch! > Also, in subr_param.c, you can assume that MSGBUF_SIZE is always defined > and always assign it as the initial value rather than having an #ifdef. Good. > Finally, I would adjust the wording in the manpage to not say that this > modifies the MSGBUF_SIZE option, but that this tunable is the same as > adjusting MSGBUF_SIZE. =A0Other than that I think it is fine. > Right. I think a simple s/Modifies/Overrides/ here will be enough. Thanks for your valuable comments. An updated patch is there: http://plukky.net/~pluknet/patches/msgbufsize.2.= diff I'm going to commit this soon. --=20 wbr, pluknet