From owner-svn-src-all@freebsd.org Fri Feb 21 01:10:34 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C9C7624C9A2 for ; Fri, 21 Feb 2020 01:10:34 +0000 (UTC) (envelope-from jroberson@jroberson.net) Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48NtgG05ffz3xBw for ; Fri, 21 Feb 2020 01:10:34 +0000 (UTC) (envelope-from jroberson@jroberson.net) Received: by mail-pf1-x441.google.com with SMTP id j9so308068pfa.8 for ; Thu, 20 Feb 2020 17:10:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jroberson-net.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=G9y+gkGgdDGc0/nufgCW5oK2QI+weKHr31BTL005eFc=; b=xwyZ5jkyF0+kCTCyfvvnjFzoGEKapEHxxZIvuLtS/pNV4zqAiedXZNqLhb5beLac+m jf79GpZFp+YVefOwdPrzEmn/OKBItPaSYk2huSF0ThThAOE4iBi0BmGjLR9qQQzvjkdn gkcddU+wyi4s7YjDsEaV3tLJI8IFb6q7RonGnFql4QmctQhIfXAOB+4PXmT2zW5oHTgv cGdQjJs9ZUoG+FoYHy/wzPS/DdHBj5vY4+Viw1H3bq/rEJhxuJql7eUvzi3h9kH5e9JC retPTzC7HRdagA5haiFETpRZ8923iST45TBiZRFtgiEvnmF/UmK7Uvv4chz7yflKMioZ 9LVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=G9y+gkGgdDGc0/nufgCW5oK2QI+weKHr31BTL005eFc=; b=YkoPOdVznh4Kcgd82eKbDMPBR/WBG/+/gbfihnlMM7SxzS/uBw8Vgrbcx4TAG+T01s tYxLM7K/Mnh0Ysb0cGc2s6VqAxBgvvUeOlrH1AfodhA52Tf8JGXAs+9zlG88kKPrwB2f jUQdFgM4hOD1H7ikzU9lbHeY0wR0awNRpzTAMVns4Ins2dFfTfdNq2+uVnEYCR5nihVS FcM8Y+8r5I3Vnl/JjUNg1K37l9ap5R6QvzyJw/g5NSZKMvs3BgX28iKfUjKA4+dHW4ly CVojzUHTnWSMgUrdX1YJMof6OifTzPlL1lxtswZSp3r9LNC9Rd+2g2bQkS1vThegHpRs i8Ow== X-Gm-Message-State: APjAAAV7AaaNMW0DiNRt9zK5Yyjh7Vs67FBYL4R5Jt74GQDcvf6Xh6m6 YIyz4U0nDYK/z7NmW2WqYzm/Jw== X-Google-Smtp-Source: APXvYqzTrJNWFlxBVENcNyQN2IvFv5mjoKaENseKv3EBKykK4kVirOv8zAl7VPo7lzK0dOHwloUrDg== X-Received: by 2002:a63:2bc3:: with SMTP id r186mr36036463pgr.294.1582247431472; Thu, 20 Feb 2020 17:10:31 -0800 (PST) Received: from rrcs-76-81-105-82.west.biz.rr.com (rrcs-76-81-105-82.west.biz.rr.com. [76.81.105.82]) by smtp.gmail.com with ESMTPSA id b186sm494424pgc.46.2020.02.20.17.10.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Feb 2020 17:10:30 -0800 (PST) Date: Thu, 20 Feb 2020 15:10:28 -1000 (HST) From: Jeff Roberson X-X-Sender: jroberson@desktop To: mmatsuda@cybernet.co.jp cc: jeff@FreeBSD.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r358097 - in head/sys: kern vm In-Reply-To: <20200221.094131.01367154.mmatsuda@cybernet.co.jp> Message-ID: References: <202002190817.01J8HRTY062438@repo.freebsd.org> <20200221.094131.01367154.mmatsuda@cybernet.co.jp> User-Agent: Alpine 2.21.9999 (BSF 287 2018-06-16) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Rspamd-Queue-Id: 48NtgG05ffz3xBw X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=jroberson-net.20150623.gappssmtp.com header.s=20150623 header.b=xwyZ5jky; dmarc=none; spf=none (mx1.freebsd.org: domain of jroberson@jroberson.net has no SPF policy when checking 2607:f8b0:4864:20::441) smtp.mailfrom=jroberson@jroberson.net X-Spamd-Result: default: False [-2.64 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[jroberson-net.20150623.gappssmtp.com:s=20150623]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; TO_DN_NONE(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[jroberson-net.20150623.gappssmtp.com:+]; RCVD_IN_DNSWL_NONE(0.00)[1.4.4.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; DMARC_NA(0.00)[jroberson.net]; FROM_EQ_ENVFROM(0.00)[]; MID_RHS_NOT_FQDN(0.50)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_TLS_ALL(0.00)[]; IP_SCORE(-0.84)[ip: (-0.58), ipnet: 2607:f8b0::/32(-1.89), asn: 15169(-1.67), country: US(-0.05)] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Feb 2020 01:10:34 -0000 On Fri, 21 Feb 2020, mmatsuda@cybernet.co.jp wrote: > Hi Jeff, > > From: Jeff Roberson > Date: Wed, 19 Feb 2020 08:17:27 +0000 (UTC) >> Author: jeff >> Date: Wed Feb 19 08:17:27 2020 >> New Revision: 358097 >> URL: https://svnweb.freebsd.org/changeset/base/358097 >> >> Log: >> Eliminate some unnecessary uses of UMA_ZONE_VM. Only zones involved in >> virtual address or physical page allocation need to be marked with this >> flag. >> >> Reviewed by: markj >> Tested by: pho >> Differential Revision: https://reviews.freebsd.org/D23712 >> >> Modified: >> head/sys/kern/subr_vmem.c >> head/sys/kern/vfs_subr.c >> head/sys/vm/swap_pager.c >> head/sys/vm/vm_page.c >> head/sys/vm/vm_pager.c >> >> Modified: head/sys/kern/subr_vmem.c >> ============================================================================== >> --- head/sys/kern/subr_vmem.c Wed Feb 19 08:15:20 2020 (r358096) >> +++ head/sys/kern/subr_vmem.c Wed Feb 19 08:17:27 2020 (r358097) >> @@ -561,8 +561,7 @@ qc_init(vmem_t *vm, vmem_size_t qcache_max) >> qc->qc_vmem = vm; >> qc->qc_size = size; >> qc->qc_cache = uma_zcache_create(qc->qc_name, size, >> - NULL, NULL, NULL, NULL, qc_import, qc_release, qc, >> - UMA_ZONE_VM); >> + NULL, NULL, NULL, NULL, qc_import, qc_release, qc, 0); >> MPASS(qc->qc_cache); >> } >> } >> @@ -668,10 +667,10 @@ vmem_startup(void) >> mtx_init(&vmem_list_lock, "vmem list lock", NULL, MTX_DEF); >> vmem_zone = uma_zcreate("vmem", >> sizeof(struct vmem), NULL, NULL, NULL, NULL, >> - UMA_ALIGN_PTR, UMA_ZONE_VM); >> + UMA_ALIGN_PTR, 0); >> vmem_bt_zone = uma_zcreate("vmem btag", >> sizeof(struct vmem_btag), NULL, NULL, NULL, NULL, >> - UMA_ALIGN_PTR, UMA_ZONE_VM | UMA_ZONE_NOFREE); >> + UMA_ALIGN_PTR, UMA_ZONE_VM); > > If I'm reading the message correctly, shouldn't the above line be like the following? > > + UMA_ALIGN_PTR, UMA_ZONE_NOFREE); In this case the commit message wasn't complete. There is no reason to mark the vmem btags as NOFREE because we can allocate them on the fly. There is a reason to mark them ZONE_VM however, because we need them to allocate virtual address space. Thanks, Jeff > > Regards, > Haro > =----------------------------------------------------------------------- > _ _ Munehiro (haro) Matsuda > -|- /_\ |_|_| Cybernet Systems Co., Ltd. > /|\ |_| |_|_| > > >