From owner-svn-src-all@freebsd.org Fri Mar 15 14:57:48 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5DF36154B1A8; Fri, 15 Mar 2019 14:57:48 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B70F36BA2E; Fri, 15 Mar 2019 14:57:47 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: by mail-lf1-x12f.google.com with SMTP id g7so7093319lfh.10; Fri, 15 Mar 2019 07:57:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=4LWf5uzi2UfHQsi6FBd69F6P6/u70BGO+6yEE497aGM=; b=XoEEs++Upkd19EYcwECY6uNkbBdl1Mtfabc99MniuPiDtb2QiXqS6lCIS4wVAw4IZi jkvASdKczzWv99UqQyo9/bi1S67o1sz7dTiHf8GhcVQsOK6AKTlJtaBC4/kP1BrwSPSQ ggK4RfpkSFFE/leF+ybtZFonUSvTjhLHlqWvRrBmMpmHULBuYU0OLxgI7Tsn77c8dbeh burp3wVUUEUMs+cGvIVulMqSJCHu9Z4mehuWhpDzBgUcWC6cnum7ONSgjLd8ForHAg4Y KKPkBjBZN+iizQ3aq/cePewQ13x0muwoc7MpfUMGMFSiialObIYYqTTYCbcfF96GPhuA K+bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=4LWf5uzi2UfHQsi6FBd69F6P6/u70BGO+6yEE497aGM=; b=Fu4tv5wr7j4ZcZCpITKg/yP8CBOlt3GuskcYoWlLrdXJodnX3Myy5CjUUB510wVasY OKHDShiOApwO5H51kOng3s7BiQubGBUbqwo3IG9tFb8kIpmEEEFlS/LvtiAQbJtiJJlm HP7cis2Ui1ansVuw3iRbpPT72ZjA6n/6MFSlJKklJguVhK+38CsjZiJih3FqST7w65Vz W0MJUBEDSVASeMgUWIUd85LINO8S3EimFjtUh/r+L+fzStpGx0xnSPtf3WEX/035OGfB Qpn9HuNv4X980ut717/Y8dx5ITDZiC96oflT/SJzW6EBfB66UyD6XAGt840eAp2+6CuT bofg== X-Gm-Message-State: APjAAAW76dPb0fzPzaevuO3hF5Lwo97N4fJRq9SXzVjCJIeL3okxg1wL tsLXhExKtpRKuAakpgOqzxzxK3TsedspQ+PXqDRee+Gw X-Google-Smtp-Source: APXvYqwOgBDK+RAdgpaWcW2COBfoJ3ruQIBTy/7OZ2E2QPqKzlT2Vb5r1iUQHCVSp6E4C0M2OBQGfbU2+Mk904toYqI= X-Received: by 2002:ac2:4109:: with SMTP id b9mr2363200lfi.109.1552661865715; Fri, 15 Mar 2019 07:57:45 -0700 (PDT) MIME-Version: 1.0 References: <201903150231.x2F2VnR6027995@gndrsh.dnsmgr.net> <7e312cdad08139c567cd43207191c97303831e9d.camel@freebsd.org> In-Reply-To: <7e312cdad08139c567cd43207191c97303831e9d.camel@freebsd.org> Reply-To: araujo@freebsd.org From: Marcelo Araujo Date: Fri, 15 Mar 2019 22:57:29 +0800 Message-ID: Subject: Re: svn commit: r345171 - head/usr.sbin/bhyve To: Ian Lepore Cc: "Rodney W. Grimes" , Chuck Tuffli , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: B70F36BA2E X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.95 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.95)[-0.947,0] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Mar 2019 14:57:48 -0000 Em sex, 15 de mar de 2019 =C3=A0s 22:12, Ian Lepore escre= veu: > On Thu, 2019-03-14 at 19:31 -0700, Rodney W. Grimes wrote: > > > Author: chuck > > > Date: Fri Mar 15 02:11:28 2019 > > > New Revision: 345171 > > > URL: https://svnweb.freebsd.org/changeset/base/345171 > > > > > > Log: > > > Fix bhyve PCIe capability emulation > > > > > > PCIe devices starting with version 1.1 must set the Role-Based > > > Error > > > Reporting bit. > > > > > > And while we're in the neighborhood, generalize the code > > > assigning the > > > device type. > > > > > > Reviewed by: imp, araujo, rgrimes > > > Approved by: imp (mentor) > > > MFC after: 1 week > > > Differential Revision: https://reviews.freebsd.org/D19580 > > > > This code requires maintainer approval before a commit, > > though this was well reviewed that doesnt exclude it > > from the MAINTAINERS entry. > > > > Where exactly does it say that in MAINTAINERS? As another victim of > this sort of drive-by lynching after making a trivial bhyve change I > pretty seriously object to a vague and meaningless entry in MAINTAINERS > being used to pounce on anyone who dares to touch the precious bhyve > code. > There is a new entry on MAINTAINERS: https://svnweb.freebsd.org/base?view=3Drevision&revision=3D344631 > > There is no mention of bhyve in MAINTAINERS, for usr.sbin or elsewhere. > There is an entry for vmm(4), which to me does not say anything about > bhyve, yet somehow everybody is supposed to know what it means and > what-all territory it covers? > > IMO, this sort of hyper-proprietary pouncing on everyone who dares > change a single line of code is not productive. It is HIGHLY de- > motivating. Large sweeping design changes are one thing, but pouncing > on every tiny minor commit is just not helpful. > +1 I got so frustrated with it recently that I have decided to don't contribute with bhyve anymore, perhaps even with FreeBSD. I still have some people under mentorship that I intend to finish and then probably I will phase out. > > -- Ian > > > Leave it for now, I am sure jhb or thyco are fine with it, > > this is just a heads up FYI for future commits. > > > > Bhyve code has been and still is under a fairly tight > > MAINTAINER status. > > > > > Modified: > > > head/usr.sbin/bhyve/pci_emul.c > > > > > > Modified: head/usr.sbin/bhyve/pci_emul.c > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > > --- head/usr.sbin/bhyve/pci_emul.c Fri Mar 15 02:11:27 2019 (= r3 > > > 45170) > > > +++ head/usr.sbin/bhyve/pci_emul.c Fri Mar 15 02:11:28 2019 (= r3 > > > 45171) > > > @@ -953,7 +953,10 @@ pci_emul_add_pciecap(struct pci_devinst *pi, > > > int type) > > > bzero(&pciecap, sizeof(pciecap)); > > > > > > pciecap.capid =3D PCIY_EXPRESS; > > > - pciecap.pcie_capabilities =3D PCIECAP_VERSION | > > > PCIEM_TYPE_ROOT_PORT; > > > + pciecap.pcie_capabilities =3D PCIECAP_VERSION | type; > > > + /* Devices starting with version 1.1 must set the RBER bit */ > > > + if (PCIECAP_VERSION >=3D 1) > > > + pciecap.dev_capabilities =3D PCIEM_CAP_ROLE_ERR_RPT; > > > pciecap.link_capabilities =3D 0x411; /* gen1, x1 */ > > > pciecap.link_status =3D 0x11; /* gen1, x1 */ > > > > > > > > > > > > > > > > --=20 --=20 Marcelo Araujo (__)araujo@FreeBSD.org \\\'',)http://www.FreeBSD.org \/ \ ^ Power To Server. .\. /_)