From owner-svn-src-all@freebsd.org  Wed May 11 20:59:14 2016
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 87BE1B37CD9;
 Wed, 11 May 2016 20:59:14 +0000 (UTC)
 (envelope-from jkim@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 0BBA818E4;
 Wed, 11 May 2016 20:59:13 +0000 (UTC)
 (envelope-from jkim@FreeBSD.org)
Subject: Re: svn commit: r299480 - head/secure/lib/libcrypto
To: Ed Maste <emaste@freebsd.org>
References: <201605112006.u4BK6NNd095917@repo.freebsd.org>
 <CAPyFy2DFrykypD7WVyJpd_hVw64ynRD0rtXwJoZn6OScba9ULg@mail.gmail.com>
Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
From: Jung-uk Kim <jkim@FreeBSD.org>
Message-ID: <24a71d4d-a500-16e1-be67-4374bbdf3307@FreeBSD.org>
Date: Wed, 11 May 2016 16:59:09 -0400
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101
 Thunderbird/45.1.0
MIME-Version: 1.0
In-Reply-To: <CAPyFy2DFrykypD7WVyJpd_hVw64ynRD0rtXwJoZn6OScba9ULg@mail.gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="qsKmiNTO5LJ8cTSK8buOVs9OqqIthnUMO"
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 11 May 2016 20:59:14 -0000

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--qsKmiNTO5LJ8cTSK8buOVs9OqqIthnUMO
Content-Type: multipart/mixed; boundary="JbpsG7WC3GR5Tmb9xlCqxWxd4pEFsMexx"
From: Jung-uk Kim <jkim@FreeBSD.org>
To: Ed Maste <emaste@freebsd.org>
Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>,
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Message-ID: <24a71d4d-a500-16e1-be67-4374bbdf3307@FreeBSD.org>
Subject: Re: svn commit: r299480 - head/secure/lib/libcrypto
References: <201605112006.u4BK6NNd095917@repo.freebsd.org>
 <CAPyFy2DFrykypD7WVyJpd_hVw64ynRD0rtXwJoZn6OScba9ULg@mail.gmail.com>
In-Reply-To: <CAPyFy2DFrykypD7WVyJpd_hVw64ynRD0rtXwJoZn6OScba9ULg@mail.gmail.com>

--JbpsG7WC3GR5Tmb9xlCqxWxd4pEFsMexx
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 05/11/16 04:43 PM, Ed Maste wrote:
> On 11 May 2016 at 16:06, Jung-uk Kim <jkim@freebsd.org> wrote:
>> Author: jkim
>> Date: Wed May 11 20:06:23 2016
>> New Revision: 299480
>> URL: https://svnweb.freebsd.org/changeset/base/299480
>>
> [...]
>>         ( echo '# $$'FreeBSD'$$' ;\
>>         echo '# Do not modify. This file is auto-generated from ${.IMP=
SRC:T}.' ;\
>>         echo '#ifdef PIC' ;\
>> -       perl ${PERLPATH} ${.IMPSRC} elf ${CFLAGS} -fpic -DPIC ;\
>> +       env CC=3Dcc perl ${PERLPATH} ${.IMPSRC} elf ${CFLAGS} -fpic -D=
PIC ;\
>>         echo '#else' ;\
>> -       perl ${PERLPATH} ${.IMPSRC} elf ${CFLAGS} ;\
>> +       env CC=3Dcc perl ${PERLPATH} ${.IMPSRC} elf ${CFLAGS} ;\
>=20
> One thing that occurred to me in the older PIC change here: perhaps we
> should explicitly strip -fpic / -DPIC from the passed-in ${CFLAGS} for
> the #else. It's unlikely, but possible, that a user could regenerate
> the assembly files with -fpic set in CFLAGS.

No user serviceable parts inside. ;-)

Seriously, there's no need for overengineering this file.

Jung-uk Kim


--JbpsG7WC3GR5Tmb9xlCqxWxd4pEFsMexx--

--qsKmiNTO5LJ8cTSK8buOVs9OqqIthnUMO
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJXM50dAAoJEHyflib82/FGdr4IAI5LaoyHPxKQnQAwtcR7jBNY
hLadqSCur2/iUg5nHKUMcKw2w3LMGP202IG8tunuS/2RIURZdq0aeLuGUMB6Hfaa
nD/z4RqQqHUrojqwyH7yeCZdPal/uQVjGJgeD5I/0Jip7K0CNQvupVwLfihcafST
W3AquzFv6PDaJK12Orv7MHijlBa5N/bcPw8sPOfOlZ/83mR3ksk6FoNJHslyHj0I
ypvQrQ5lMkyoQt912K2FeKbS86Wxav4vT2MRxBYRDZjVnT7pgZTBTf0R4lJ83oQb
epHmgKTKcYTCr0WtnQqcMV+21tBLUliBptOjDmj+dfRp0b3iYzeIR2yrB3oVwdo=
=znAV
-----END PGP SIGNATURE-----

--qsKmiNTO5LJ8cTSK8buOVs9OqqIthnUMO--