From owner-cvs-src@FreeBSD.ORG Tue Jan 8 19:07:26 2008 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4C1C016A420; Tue, 8 Jan 2008 19:07:26 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (tim.des.no [194.63.250.121]) by mx1.freebsd.org (Postfix) with ESMTP id 04B8D13C45A; Tue, 8 Jan 2008 19:07:25 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (localhost [127.0.0.1]) by spam.des.no (Postfix) with ESMTP id C87E52089; Tue, 8 Jan 2008 20:07:18 +0100 (CET) X-Spam-Tests: AWL X-Spam-Learn: disabled X-Spam-Score: -0.2/3.0 X-Spam-Checker-Version: SpamAssassin 3.2.3 (2007-08-08) on tim.des.no Received: from ds4.des.no (des.no [80.203.243.180]) by smtp.des.no (Postfix) with ESMTP id 49044207E; Tue, 8 Jan 2008 20:07:18 +0100 (CET) Received: by ds4.des.no (Postfix, from userid 1001) id 2C4F38449F; Tue, 8 Jan 2008 20:07:18 +0100 (CET) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: pav@FreeBSD.org References: <200801080800.m08806jI012963@repoman.freebsd.org> <1199816405.74596.136.camel@ikaros.oook.cz> <86ir24nokg.fsf@ds4.des.no> <1199818149.74596.150.camel@ikaros.oook.cz> Date: Tue, 08 Jan 2008 20:07:18 +0100 In-Reply-To: <1199818149.74596.150.camel@ikaros.oook.cz> (Pav Lucistnik's message of "Tue\, 08 Jan 2008 19\:49\:09 +0100") Message-ID: <86ejcsnnkp.fsf@ds4.des.no> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.1 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/unzip Makefile unzip.1 unzip.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jan 2008 19:07:26 -0000 Pav Lucistnik writes: > BTW are you planning to do a __FreeBSD_version change for this unzip > import? So we have something to .if around in bsd.port.mk in future... Not until libarchive has learned to handle those last four zipfiles. There are other things that need to change as well; for instance, the current USE_ZIP code will consider the dependency satisfied if e.g. /usr/bin/unzip exists, yet hardcodes ${LOCALBASE}/bin/unzip in do-extract, so if I connected src/usr.bin/unzip to the build without first changing bsd.ports.mk, all the USE_ZIP ports would break. Apart from these four files, by the way, the difficulty lies in the hairy command-line syntax (to avoid changing the ports) and the need to perform ceratin manipulations like lowercasing the name of each file as you extract it or converting DOS line endings on the fly. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no