From nobody Wed Jul 29 17:49:38 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4h9KbR2491z6mZct for ; Wed, 29 Jul 2026 17:49:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4h9KbQ6Dmqz3lGq for ; Wed, 29 Jul 2026 17:49:38 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785347378; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=sL4K8I2vEUxIQdParDd8j0YzVmIpdeUWhYhVXTNCzFs=; b=fpsXvLyF332MBOuvMRfOdo0cWUrM9hr0clqQaAS+aUEYtM2hYRSzzUkXwDVuUSUkALD+A1 s/2bUMpk4CbzOJWAP4T3t3UzpCl+0uzSWoQSa2drafgavgfJMVIElQiiQVMSlYEb7iHxim tXMkP22GxaayPxGg0uwjfeGZdtzjW8TeAYO/eQZrtT05tDDiSIixg1eqHjJX6AtWbhSXjJ 2KhgjtP5bH0NUHUaukCBcPHBc9yJ01JvoVIzUYSCSzqEyS/TMTjxKlMcvqZB9Asn755Rbh 1sEUpBMtvOEaqaT9SuadCp+fQtcMflKgpGLGPiUr+TChGlvIzHzgb8MiCmfnlg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785347378; a=rsa-sha256; cv=none; b=umJU4uz1MesRMQA2Bz2SsUT6BRzYPqg36h6SAOTJyQrVnBuOJUjkiA6IN0+mErhDeLrQ5Y UFU1s1K1c1ae2zIp9LTdjEp63kt1bEebRPvjwlexWBAFP1XA2kQCwUIw2h13jUMeBUudyv Iah3h6qQSKdqLbq72N2Gvwp63shDowE2juJkQnr8iV8pExpLNdIMOlWGwmQvV6iGd/h2vr 44O6NfIg4Z+N6JioJusrFcKHUIWwl5LpGIj1IkT3zbQF8/VFAYfJ1OsF3Vz40Zu+WIj8Gf yN/O5iqRKFjrEPDc3F34TD0CLIkP0+Oz2nthpUkFIqNMDOp1QuTRbhMD2ETkNQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785347378; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=sL4K8I2vEUxIQdParDd8j0YzVmIpdeUWhYhVXTNCzFs=; b=On+iHTBoYWuSEuCvIjyA5T9KM8wICZnZ8cpva+kY2VOqoziDbLO/GWP0Io2FbEEqs3DB8R JKYipK9UY/ci1EX4TTdtQ2H+pCuIgjTC6Zw0zQbgBzIGQGD0TrYy+vhpchOJlqMPRwNo+4 Jo3DTDBaWLj1Y/62vEXT2wvA4mdeI6Ls4a6GPZ8JAYlo3V7PuHnh0yF+u4qUr43s3gJgrQ IJC0DVpy1Xal7VK0e4YY/lxkZft0oo5gcljS8zYcjlLLQZCxGYi4JYZlNB+lAhPN5mFCNe Ye74yWnzCXvtpKvJZPdBxDqQW+0ydCfppnk7k/EhSTzasg4y5NmzbLUsQoCG2w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4h9KbQ5CWmzd9S for ; Wed, 29 Jul 2026 17:49:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 39d7a by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 29 Jul 2026 17:49:38 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: d46ec216104e - releng/14.4 - coredump: Don't assume that the number of ELF segments is consistent List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/releng/14.4 X-Git-Reftype: branch X-Git-Commit: d46ec216104e2f8e6f0eb9f1967c772e54eeda54 Auto-Submitted: auto-generated Date: Wed, 29 Jul 2026 17:49:38 +0000 Message-Id: <6a6a3d32.39d7a.3f2cd528@gitrepo.freebsd.org> The branch releng/14.4 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=d46ec216104e2f8e6f0eb9f1967c772e54eeda54 commit d46ec216104e2f8e6f0eb9f1967c772e54eeda54 Author: Mark Johnston AuthorDate: 2026-07-27 15:42:49 +0000 Commit: Mark Johnston CommitDate: 2026-07-28 14:38:27 +0000 coredump: Don't assume that the number of ELF segments is consistent In an ELF coredump, each dumped vm_map_entry is represented by a segment. __elfN(coredump) first computes the number of segments by looping over the vm_map entries (in each_dumpable_segment()), then allocates a buffer to hold the ELF header and program headers, then loops over the entries again to populate the program headers. each_dumpable_segment() holds the vm_map read lock, but that lock is dropped between the two calls. If the map is shared with another process, via rfork(), then the map can change. cb_put_phdr() did not account for this, and so could write out of bounds. Add a check to prevent this; simply do not write out excess segments. Approved by: so Security: FreeBSD-SA-26:55.elf Security: CVE-2026-58088 Reported by: Maik Muench of Secfault Security Reviewed by: kib, emaste Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D58416 --- sys/kern/imgact_elf.c | 22 +++++++++++++++++++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/sys/kern/imgact_elf.c b/sys/kern/imgact_elf.c index df9156ad76ca..e1a0f49e700c 100644 --- a/sys/kern/imgact_elf.c +++ b/sys/kern/imgact_elf.c @@ -1533,6 +1533,8 @@ typedef void (*segment_callback)(vm_map_entry_t, void *); struct phdr_closure { Elf_Phdr *phdr; /* Program header to fill in */ Elf_Off offset; /* Offset of segment in core file */ + int numsegs; /* Maximum number of segments */ + int nextseg; /* Next segment to fill in */ }; struct note_info { @@ -1647,10 +1649,15 @@ __elfN(coredump)(struct thread *td, struct vnode *vp, off_t limit, int flags) } /* - * Allocate memory for building the header, fill it up, - * and write it out following the notes. + * Allocate memory for building the header, fill it up, and write it out + * following the notes. + * + * Note that a process sharing our vmspace might be concurrently + * mutating the map, in which case we could populate fewer than + * seginfo.count headers. Zero the buffer to ensure that unpopulated + * headers are still initialized. */ - hdr = malloc(hdrsize, M_TEMP, M_WAITOK); + hdr = malloc(hdrsize, M_TEMP, M_WAITOK | M_ZERO); error = __elfN(corehdr)(¶ms, seginfo.count, hdr, hdrsize, ¬elst, notesz, flags); @@ -1703,6 +1710,11 @@ cb_put_phdr(vm_map_entry_t entry, void *closure) struct phdr_closure *phc = (struct phdr_closure *)closure; Elf_Phdr *phdr = phc->phdr; + if (phc->nextseg >= phc->numsegs) { + /* Only write as many headers as we have space for. */ + return; + } + phc->offset = round_page(phc->offset); phdr->p_type = PT_LOAD; @@ -1715,6 +1727,8 @@ cb_put_phdr(vm_map_entry_t entry, void *closure) phc->offset += phdr->p_filesz; phc->phdr++; + + phc->nextseg++; } /* @@ -1977,6 +1991,8 @@ __elfN(puthdr)(struct thread *td, void *hdr, size_t hdrsize, int numsegs, /* All the writable segments from the program. */ phc.phdr = phdr; phc.offset = round_page(hdrsize + notesz); + phc.numsegs = numsegs; + phc.nextseg = 0; each_dumpable_segment(td, cb_put_phdr, &phc, flags); }