From owner-freebsd-current@FreeBSD.ORG Tue Jan 20 03:59:43 2009 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 93DD9106566B for ; Tue, 20 Jan 2009 03:59:43 +0000 (UTC) (envelope-from andy@siliconlandmark.com) Received: from lexi.siliconlandmark.com (lexi.siliconlandmark.com [66.184.117.4]) by mx1.freebsd.org (Postfix) with ESMTP id 612E78FC0A for ; Tue, 20 Jan 2009 03:59:43 +0000 (UTC) (envelope-from andy@siliconlandmark.com) Received: from [10.0.1.102] (c-76-112-231-135.hsd1.mi.comcast.net [76.112.231.135]) (authenticated bits=0) by lexi.siliconlandmark.com (8.14.2/8.14.2) with ESMTP id n0K3xdAg026086 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Tue, 20 Jan 2009 03:59:39 GMT (envelope-from andy@siliconlandmark.com) Message-Id: <129DC2F8-C5ED-4382-957A-29B5DBE2FCC9@siliconlandmark.com> From: Andre Guibert de Bruet To: Hans Petter Selasky In-Reply-To: <24019.1232155811@critter.freebsd.dk> Content-Type: multipart/mixed; boundary=Apple-Mail-10-713703121 Mime-Version: 1.0 (Apple Message framework v930.3) Date: Mon, 19 Jan 2009 22:59:33 -0500 References: <24019.1232155811@critter.freebsd.dk> X-Mailer: Apple Mail (2.930.3) X-Virus-Scanned: ClamAV 0.94.1/8878/Mon Jan 19 22:01:48 2009 on lexi.siliconlandmark.com X-Virus-Status: Clean Cc: current@freebsd.org Subject: Re: [Lcdproc] LCDProc CVS + PicoLCD on FreeBSD X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jan 2009 03:59:43 -0000 --Apple-Mail-10-713703121 Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit On Jan 16, 2009, at 8:30 PM, Poul-Henning Kamp wrote: > In message A42CF4263B9E@siliconlandmark.com>, Andre Guibert de Bruet writes: > >>>>> ...but... they *are* HID devices. Why is this "unfortunate"? >>> >>> It's unfortunate, because they are HID devices only because that >>> is what microchip.com supplies as a USB programming example. >>> >>> The actual protocol they talk has nothing to do with the HID >>> specification. >> >> PHK - I see that you committed the quirk for the 2X20. Would you mind >> committing the patch attached to PR usb/128803? Do you want me to >> produce the bits required for usb2 as well? > > USB2 patches should go to HPS@ still I think ? I have attached the 4x20 quirk patch for hpsusb. Thanks for all of your hard work! Cheers, Andy /* Andre Guibert de Bruet * 436f 6465 2070 6f65 742e 2042 6974 206a */ /* Managing Partner * 6f63 6b65 792e 2053 7973 4164 6d69 6e2e */ /* GSM: +1 734 846 8758 * 2055 4e49 5820 736c 6575 7468 2e00 0000 */ /* WWW: siliconlandmark.com * C/C++, Java, Perl, PHP, SQL, XHTML, XML */ --Apple-Mail-10-713703121 Content-Disposition: attachment; filename=picolcd.usb2.quirk.diff Content-Type: application/octet-stream; x-unix-mode=0644; name="picolcd.usb2.quirk.diff" Content-Transfer-Encoding: 7bit Index: sys/dev/usb2/include/usb2_devtable.h =================================================================== --- sys/dev/usb2/include/usb2_devtable.h (revision 187457) +++ sys/dev/usb2/include/usb2_devtable.h (working copy) @@ -3401,6 +3401,12 @@ "USB-LCD 2x20", }, { + USB_VENDOR_ITUNERNET, USB_PRODUCT_ITUNERNET_USBLCD4X20, + 0, + "I-Tuner Networks", + "USB-LCD 4x20", + }, + { USB_VENDOR_JABLOTRON, USB_PRODUCT_JABLOTRON_PC60B, 0, "Jablotron", Index: sys/dev/usb2/include/usb2_devid.h =================================================================== --- sys/dev/usb2/include/usb2_devid.h (revision 187457) +++ sys/dev/usb2/include/usb2_devid.h (working copy) @@ -1511,6 +1511,7 @@ /* Ituner networks products */ #define USB_PRODUCT_ITUNERNET_USBLCD2X20 0x0002 /* USB-LCD 2x20 */ +#define USB_PRODUCT_ITUNERNET_USBLCD4X20 0xc001 /* USB-LCD 4x20 */ /* Jablotron products */ #define USB_PRODUCT_JABLOTRON_PC60B 0x0001 /* PC-60B */ Index: sys/dev/usb2/quirk/usb2_quirk.c =================================================================== --- sys/dev/usb2/quirk/usb2_quirk.c (revision 187457) +++ sys/dev/usb2/quirk/usb2_quirk.c (working copy) @@ -95,6 +95,7 @@ {USB_QUIRK_ENTRY(USB_VENDOR_CYBERPOWER, USB_PRODUCT_CYBERPOWER_1500CAVRLCD, 0x0000, 0xFFFF, UQ_HID_IGNORE, UQ_NONE)}, {USB_QUIRK_ENTRY(USB_VENDOR_DELORME, USB_PRODUCT_DELORME_EARTHMATE, 0x0000, 0xFFFF, UQ_HID_IGNORE, UQ_NONE)}, {USB_QUIRK_ENTRY(USB_VENDOR_ITUNERNET, USB_PRODUCT_ITUNERNET_USBLCD2X20, 0x0000, 0xFFFF, UQ_HID_IGNORE, UQ_NONE)}, + {USB_QUIRK_ENTRY(USB_VENDOR_ITUNERNET, USB_PRODUCT_ITUNERNET_USBLCD4X20, 0x0000, 0xFFFF, UQ_HID_IGNORE, UQ_NONE)}, {USB_QUIRK_ENTRY(USB_VENDOR_MGE, USB_PRODUCT_MGE_UPS1, 0x0000, 0xFFFF, UQ_HID_IGNORE, UQ_NONE)}, {USB_QUIRK_ENTRY(USB_VENDOR_MGE, USB_PRODUCT_MGE_UPS2, 0x0000, 0xFFFF, UQ_HID_IGNORE, UQ_NONE)}, {USB_QUIRK_ENTRY(USB_VENDOR_APPLE, USB_PRODUCT_APPLE_IPHONE, 0x0000, 0xFFFF, UQ_HID_IGNORE, UQ_NONE)}, --Apple-Mail-10-713703121 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit --Apple-Mail-10-713703121--