Date: Thu, 13 Oct 2016 10:59:44 -0400 From: Kris Moore <kmoore@freebsd.org> To: Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r423922 - in head/security: . ngrok Message-ID: <d7c1b966-5647-a976-8030-e9ce35baae8f@freebsd.org> In-Reply-To: <773bb4e0-00d2-6234-33ae-fdafce1135a7@FreeBSD.org> References: <201610131431.u9DEVcA7079532@repo.freebsd.org> <773bb4e0-00d2-6234-33ae-fdafce1135a7@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10/13/2016 10:42, Mathieu Arnold wrote: > Le 13/10/2016 =C3=A0 16:31, Kris Moore a =C3=A9crit : >> +PORTNAME=3D ngrok >> +PORTVERSION=3D 2.1.14 >> +CATEGORIES=3D security >> +MASTER_SITES=3D https://bin.equinox.io/c/4VmDzA7iaHb/ >> +DISTNAME=3D ${PORTNAME}-stable-freebsd-${NGROK_ARCH} >> > The DISTNAME seems to not have PORTVERSION in it. It means that when th= e > software is updated, there will be a second distfile with the same name= , > which is a bad thing. For those case, you should add: > > DIST_SUBDIR=3D ${PORTNAME}/${PORTVERSIONS} > > or something, so that there cannot be two different files with the same > name. > > Good catch! I've added that now.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d7c1b966-5647-a976-8030-e9ce35baae8f>