Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 23 Feb 2010 11:33:49 +0100
From:      =?ISO-8859-1?Q?Ermal_Lu=E7i?= <ermal.luci@gmail.com>
To:        freebsd-net <freebsd-net@freebsd.org>
Subject:   CSUM_TSO question...
Message-ID:  <9a542da31002230233o24aa8db3nc77017fbe141a1fc@mail.gmail.com>

next in thread | raw e-mail | index | archive | help
Hello all,
i was reading ip_output() code today and stumbled accross this
http://fxr.watson.org/fxr/source/netinet/ip_output.c#L587.

Can anybody shad any light on the check being done ?
(m->m_pkthdr.csum_flags & ifp->if_hwassist & CSUM_TSO) != 0 ||

Shouldn't it be just
(m->m_pkthdr.csum_flags & CSUM_TSO) != 0 ||
or it shold be
(ifp->if_hwassist & CSUM_TSO) != 0 ||

while just a few lines above the following computation is done
m->m_pkthdr.csum_flags &= ifp->if_hwassist;

I am not sure how the compiler interprets it and it might be right
though reading it is somewhat not clear what is going on.

Is this correct?

Regards,
--
Ermal



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9a542da31002230233o24aa8db3nc77017fbe141a1fc>