From owner-svn-src-stable@FreeBSD.ORG Fri Aug 30 08:54:40 2013 Return-Path: Delivered-To: svn-src-stable@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id B23A762B; Fri, 30 Aug 2013 08:54:40 +0000 (UTC) (envelope-from Andre.Albsmeier@siemens.com) Received: from goliath.siemens.de (goliath.siemens.de [192.35.17.28]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 41018233A; Fri, 30 Aug 2013 08:54:39 +0000 (UTC) Received: from mail2.siemens.de (localhost [127.0.0.1]) by goliath.siemens.de (8.13.6/8.13.6) with ESMTP id r7U8sVsM010454; Fri, 30 Aug 2013 10:54:31 +0200 Received: from curry.mchp.siemens.de (curry.mchp.siemens.de [139.25.40.130]) by mail2.siemens.de (8.13.6/8.13.6) with ESMTP id r7U8sVNB012414; Fri, 30 Aug 2013 10:54:31 +0200 Received: (from localhost) by curry.mchp.siemens.de (8.14.7/8.14.7) id r7U8sV2S001603; Date: Fri, 30 Aug 2013 10:54:31 +0200 From: Andre Albsmeier To: Erwin Lansing Subject: Re: svn commit: r254897 - in stable/9: contrib/bind9 contrib/bind9/bin contrib/bind9/bin/check contrib/bind9/bin/confgen contrib/bind9/bin/dig contrib/bind9/bin/dig/include/dig contrib/bind9/bin/dnssec... Message-ID: <20130830085431.GA4707@bali> References: <201308260717.r7Q7HgMF073297@svn.freebsd.org> <20130829075631.GA96113@bali> <20130830062152.GL83309@droso.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20130830062152.GL83309@droso.dk> X-Echelon: X-Advice: Drop that crappy M$-Outlook, I'm tired of your viruses! User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-stable@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, svn-src-stable-9@FreeBSD.org, Andre Albsmeier X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Aug 2013 08:54:40 -0000 On Fri, 30-Aug-2013 at 08:21:52 +0200, Erwin Lansing wrote: > Hi Andre, >=20 > On Thu, Aug 29, 2013 at 09:56:31AM +0200, Andre Albsmeier wrote: > > On Mon, 26-Aug-2013 at 07:17:42 +0000, Erwin Lansing wrote: > > > Author: erwin > > > Date: Mon Aug 26 07:17:41 2013 > > > New Revision: 254897 > > > URL: http://svnweb.freebsd.org/changeset/base/254897 > > >=20 > > > Log: > > > MFC r254651: > > > =20 > > > Update Bind to 9.9.3-P2 > >=20 > > Thanks! > >=20 > > However, when enabling WITH_BIND_SIGCHASE in make.conf I get: > >=20 > > cc -O2 -pipe -DVERSION=3D'"9.9.3-P2"' -DHAVE_CONFIG_H -D_REENTRANT -D_T= HREAD_SAFE -DOPENSSL -DUSE_MD5 -DNS_LOCALSTATEDIR=3D'"/var"' -DNS_SYSCONFDI= R=3D'"/etc/namedb"' -DNAMED_CONFFILE=3D'"/etc/namedb/named.conf"' -DRNDC_CO= NFFILE=3D'"/etc/namedb/rndc.conf"' -DRNDC_KEYFILE=3D'"/etc/namedb/rndc.key"= ' -I/src/src-9/usr.bin/dig/../../lib/bind -DDIG_SIGCHASE -I/src/src-9/usr.b= in/dig/../../contrib/bind9/lib/bind9/include -I/src/src-9/usr.bin/dig/../..= /contrib/bind9/lib/dns/include/dst -I/src/src-9/usr.bin/dig/../../contrib/= bind9/lib/dns/include -I/src/src-9/usr.bin/dig/../../lib/bind/dns -I/src/s= rc-9/usr.bin/dig/../../contrib/bind9/lib/isccc/include -I/src/src-9/usr.bin= /dig/../../contrib/bind9/lib/isccfg/include -I/src/src-9/usr.bin/dig/../../= contrib/bind9/lib/isc/unix/include -I/src/src-9/usr.bin/dig/../../contrib/= bind9/lib/isc/pthreads/include -I/src/src-9/usr.bin/dig/../../contrib/bind= 9/lib/isc/include -I/src/src-9/usr.bin/dig/../../lib/bind/isc -I/src/src-9= /usr.bin/dig/../../contrib/bind9/lib/lwres/unix/include -I/src/src-9/usr.b= in/dig/../../contrib/bind9/lib/lwres/include -I/src/src-9/usr.bin/dig/../.= =2E/lib/bind/lwres -I/src/src-9/usr.bin/dig/../../contrib/bind9/bin/dig/inc= lude -I/src/src-9/usr.bin/dig/../../contrib/bind9/lib/isc/x86_32/include -U= ENABLE_ALTQ -std=3Dgnu99 -fstack-protector -Wsystem-headers -Werror -Wno-po= inter-sign -c /src/src-9/usr.bin/dig/../../contrib/bind9/bin/dig/dighost.c > > cc1: warnings being treated as errors > > /src/src-9/usr.bin/dig/../../contrib/bind9/bin/dig/dighost.c: In functi= on 'nameFromString': > > /src/src-9/usr.bin/dig/../../contrib/bind9/bin/dig/dighost.c:4336: warn= ing: passing argument 2 of 'isc__buffer_init' discards qualifiers from poin= ter target type > > *** [dighost.o] Error code 1 > >=20 > > How should we deal with this? > >=20 > > Changing the Makefiles of dig, host and nslookup to WARNS?=3D0 > > or patching dighost.c in contrib/bind9 directly? > >=20 >=20 > Thanks for the report. I have just reduced WARNS to 0 for those 3 in > HEAD and will MFC early next week. Thanks. Maybe we want to ifdef the WARNS setting according to BIND_SIGCHASE? -Andre